Skip to content

docs: fix copy-paste errors in v5.4 field-level CSV#783

Open
haoyu-haoyu wants to merge 1 commit intoOHDSI:mainfrom
haoyu-haoyu:fix/cdm-v54-field-level-typos
Open

docs: fix copy-paste errors in v5.4 field-level CSV#783
haoyu-haoyu wants to merge 1 commit intoOHDSI:mainfrom
haoyu-haoyu:fix/cdm-v54-field-level-typos

Conversation

@haoyu-haoyu
Copy link
Copy Markdown

Fixes several copy-paste errors in inst/csv/OMOP_CDMv5.4_Field_Level.csv:

"Standard Condition Concept" in non-condition fields:

  • observation.unit_source_value ETL convention said "Standard Condition Concept" — changed to "Standard Concept"
  • observation.qualifier_source_value — same fix
  • device_exposure.unit_source_value — same fix

These were clearly copy-pasted from condition_occurrence field descriptions.

Deprecated v6 references:

  • Removed ", though it is in v6" from datetime field descriptions for drug_exposure, device_exposure, and measurement. Since v6 has been deprecated this mention is confusing for new users.

Addresses items 1, 2, 6, and 8 from #702.

Fix incorrect ETL convention descriptions in OMOP_CDMv5.4_Field_Level.csv:

- observation.unit_source_value: "Standard Condition Concept" -> "Standard Concept"
- observation.qualifier_source_value: same fix
- device_exposure.unit_source_value: same fix
  (These were copy-pasted from condition_occurrence fields)

- Remove "though it is in v6" from 4 datetime field descriptions
  (drug_exposure, device_exposure, measurement) since v6 has been
  deprecated and the mention confuses new users.

Addresses items 1, 2, 6, and 8 from OHDSI#702.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant