[MIG] spreadsheet_*: Migration from 18.0 to 19.0

[susaglam]

Summary

Migrate all four OCA spreadsheet modules from 18.0 to 19.0, including
compatibility fixes discovered during CI validation and runtime testing.
The runtime pass uncovered two additional chart-side-panel crashes in
Odoo 19's o-spreadsheet; the fixes are included in this PR.

Modules migrated

• spreadsheet_oca (18.0.1.3.0 → 19.0.1.0.0)
• spreadsheet_dashboard_oca (18.0.1.1.0 → 19.0.1.0.0)
• spreadsheet_dashboard_purchase_oca (18.0.1.0.0 → 19.0.1.0.0)
• spreadsheet_dashboard_purchase_stock_oca (18.0.1.0.0 → 19.0.1.0.0)

Python changes

• Remove "version": 1 from empty spreadsheet data in spreadsheet_abstract.py to match upstream spreadsheet.mixin behavior in Odoo 19

• Remove loadSpreadsheetDependencies() import and call — Chart.js is now auto-included in spreadsheet.o_spreadsheet bundle via Odoo 19 manifest

• Migrate _sql_constraints list format to models.Constraint() class attribute in spreadsheet_spreadsheet_tag.py

• Migrate _() translations to self.env._() in all model files — the new Odoo 19 convention that closes over env context automatically (fixes pylint-odoo W8161 prefer-env-translation):

  • spreadsheet_dashboard_oca/models/spreadsheet_dashboard.py (2 call sites)
  • spreadsheet_oca/models/spreadsheet_abstract.py (1 call site)
  • spreadsheet_oca/models/spreadsheet_spreadsheet.py (1 call site)
  • Removed unused from odoo import _ imports

• Wrap default=_get_default_color with a lambda in spreadsheet_spreadsheet_tag.py so the default method remains inheritable in subclasses (fixes pylint-odoo E8148 inheritable-method-lambda):

  default=lambda self: self._get_default_color()

JavaScript changes

Core asset & registry migration

• Fix JS import path: @spreadsheet/assets_backend/helpers → @spreadsheet/helpers/helpers (file relocated in Odoo 19)
• Remove duplicate topbarMenuRegistry.add("file") — already registered by o-spreadsheet core library in Odoo 19
• Remove duplicate topbarMenuRegistry.addChild("settings") — already registered by core
• Use safe registry additions (try/catch with .replace() fallback) for chartSubtypeRegistry, chartSidePanelComponentRegistry, sidePanelRegistry, and pivotSidePanelRegistry to prevent "already present in this registry!" crashes

ListView template changes

• Fix ListView button xpath: in Odoo 19 the web.ListView.Buttons template no longer wraps its children in a <div class="o_list_buttons"> — buttons are direct children of the template root. The old xpath caused an OWL crash (Element cannot be located in element tree) when opening the spreadsheet list view. Target the o_list_button_add button instead.
• Fix ListView Upload button positioning: target control-panel-create-button slot directly instead of parent element (template structure changed in 19)

Chart side-panel API migration

Discovered at runtime after the module initially installed cleanly: clicking
any chart produced a JS crash that made the whole chart feature unusable.
Two coordinated o-spreadsheet API changes required fixes:

Component prop rename (figureId → chartId) — commit 2e17e44

o-spreadsheet 19.0 renamed the identifying prop on every chart-related
side-panel component:

Component	Old prop	New prop
ChartTypePicker	figureId	chartId
GenericChartConfigPanel	figureId	chartId
LineConfigPanel	figureId	chartId
BarConfigPanel	figureId	chartId
ScorecardChartConfigPanel	figureId	chartId
GaugeChartConfigPanel	figureId	chartId

New props contract:

static props = { chartId: String, definition, canUpdateChart, updateChart };

Our patches still read this.props.figureId → undefined →
getChartDefinition(undefined) throws Chart with id undefined does not exist.
Fix: rename figureId → chartId in chart_panel.esm.js and
chart_panels.esm.js; rename internal helper getFigureDefinition →
getChartDefinition; add defensive early-return for a briefly undefined
chartId during initial component mount.

Chart-menu link API rename — commit 4f51879

o-spreadsheet 19.0 restructured the chart → Odoo-menu link into a generic
typed-link API:

// OLD
env.model.getters.getChartOdooMenu(chartId)   // returns menu object
dispatch("LINK_ODOO_MENU_TO_CHART", { chartId, odooMenuId })

// NEW
env.model.getters.getChartOdooLink(chartId)   // returns OdooLink | undefined
// then:
env.model.getters.getIrMenu(link.odooMenuId)
dispatch("UPDATE_ODOO_LINK_TO_CHART", {
  chartId,
  odooLink: { type: "odooMenu", odooMenuId },
})

OdooLink shape (from addons/spreadsheet/static/src/chart/plugins/chart_odoo_link_plugin.js):

type OdooLink =
  | { type: "odooMenu";    odooMenuId: number | string }
  | { type: "dataSource";  dataSourceType: string; dataSourceCoreId: string }
  | undefined   // passing undefined as odooLink unlinks

Symptom before this fix: OWL lifecycle crash on any chart panel render —
TypeError: this.env.model.getters.getChartOdooMenu is not a function at
menuId getter. Fix: resolve via getChartOdooLink with type guard; dispatch
UPDATE_ODOO_LINK_TO_CHART with the typed payload; pass
odooLink: undefined to unlink.

XML / Security changes

• Remove category_id field from res.groups records in security.xml (field removed in Odoo 19)
• Remove users field from res.groups records in security.xml (field renamed to user_ids in Odoo 19)
• Implement Odoo 19 privilege system: create res.groups.privilege record linked to ir.module.category so spreadsheet groups appear in user settings with selectable options (No Access / User / Manager)
• Rename groups_id → group_ids on ir.ui.menu records in spreadsheet_spreadsheet.xml (field renamed in Odoo 19)
• Rename user.groups_id → user.group_ids in all domain rules in security.xml (field renamed in Odoo 19)

Dashboard data fixes

• spreadsheet_dashboard_purchase_stock_oca/data/files/purchase_dashboard.json: replace date with scheduled_date for the stock.picking list. The date field was renamed to scheduled_date on stock.picking in Odoo 19. Affected:

  • list columns definition
  • list orderBy clause
  • 10 ODOO.LIST(3, *, "date") cell references on the Dashboard sheet

  Without this fix module install fails with:

  field 'date' used in spreadsheet 'Purchase' does not exist
  on model 'stock.picking'
  

Formatting / tooling

• Prettier: reformat purchase_dashboard.json (compact arrays within printWidth, trailing newline) to pass OCA pre-commit
• Prettier: multi-line sidePanelRegistry.add() / .replace() object literals in filter.esm.js and filter_panel_datasources.esm.js
• Prettier: multi-line xpath attribute in list_controller.xml

No changes required

• Asset bundle names (web.assets_backend, web.assets_backend_lazy) remain valid in Odoo 19.0
• All Python models already use modern ORM patterns
• All XML views already use invisible= and <list>
• All JS code uses ES6/OWL patterns

Testing performed

All items below were manually tested on Odoo 19.0:

• Install all four modules from a clean database without errors
• Spreadsheet list / kanban / form views load correctly
• Create a new spreadsheet and open without errors
• Import a pivot table from pivot view
• Import a list from list view (Upload button positioned correctly)
• Import a graph from graph view
• Global filters panel works
• Download spreadsheet as XLSX
• Purchase dashboard renders the stock.picking Transfers list (previously crashed because of date field)
• User access control visible in Settings → Users with tiered dropdown (No Access / User / Manager)
• No JS registry "already present" errors in browser console
• Insert a chart into a spreadsheet — no Chart with id undefined error
• Open Bar / Line / Scorecard / Gauge chart side panels — no OWL lifecycle error
• Change chart type via the type picker — dispatch succeeds
• Link an Odoo menu via the "Menu Items" dropdown — persists on reload
• Unlink the menu (clear selection) — getChartOdooLink returns undefined

References

• o-spreadsheet source, chart_type_picker.ts: static props = { chartId: String, chartPanelStore: Object }
• o-spreadsheet source, common.ts: ChartSidePanelPropsObject declares chartId: String + updateChart, canUpdateChart, definition
• Odoo saas-19.2 source, chart_odoo_link_plugin.js: defines the getChartOdooLink getter, UPDATE_ODOO_LINK_TO_CHART command, and OdooLink type (odooMenu | dataSource)

CI status

All 7 checks pass on the latest push:

Check	Status
codecov/patch	✅
codecov/project	✅
pre-commit (prettier, eslint, pylint-odoo)	✅
runboat/build	✅
tests / Detect unreleased dependencies	✅
tests / test with OCB	✅
tests / test with Odoo	✅

[sonasxo-art]

To Reproduce

Affected versions: Odoo 19.0 with spreadsheet_oca module (19.0 branch)

Steps to reproduce the behavior:

1. Open Odoo 19.0
2. Create or open a spreadsheet
3. Add a chart to the spreadsheet
4. Attempt to perform operations in the chart panel
5. Click on interactive elements in the chart panel

Expected behavior
The chart should operate normally without errors.

Actual behavior

• JavaScript error "Chart with id undefined does not exist" appears
• Chart panel crashes and becomes unusable
• The entire chart functionality is affected

Additional context

• Operating System: Any
• Odoo Version: 19.0
• Branch: 19.0
• Browser: Chrome
• Date: 2026-04-20 06:51:00 GMT

[susaglam]

To Reproduce

Affected versions: Odoo 19.0 with spreadsheet_oca module (19.0 branch)

Steps to reproduce the behavior:

1. Open Odoo 19.0
2. Create or open a spreadsheet
3. Add a chart to the spreadsheet
4. Attempt to perform operations in the chart panel
5. Click on interactive elements in the chart panel

Expected behavior The chart should operate normally without errors.

Actual behavior

• JavaScript error "Chart with id undefined does not exist" appears
• Chart panel crashes and becomes unusable
• The entire chart functionality is affected

Additional context

• Operating System: Any
• Odoo Version: 19.0
• Branch: 19.0
• Browser: Chrome
• Date: 2026-04-20 06:51:00 GMT

thanks for the report. Commit fixes it.

Root cause: o-spreadsheet 19.0 renamed the chart identifier prop from
figureId to chartId on ChartTypePicker and all config panels
(GenericChartConfigPanel, LineConfigPanel, BarConfigPanel,
ScorecardChartConfigPanel, GaugeChartConfigPanel). Our patches
still read this.props.figureId → undefined → getChartDefinition(undefined) throws.

Fix:

• this.props.figureId → this.props.chartId in both chart_panel.esm.js
  and chart_panels.esm.js
• Added if (!chartId) return super.onTypeChange(type) defensive guard
• Renamed internal helper getFigureDefinition → getChartDefinition for consistency

References:

• ChartTypePicker.ts in o-spreadsheet core: static props = { chartId: String, chartPanelStore: Object }

Please pull and retest.