[FIX] tracking_manager: float value precision - #3711
Open
maciej-wichowski wants to merge 1 commit into
Open
Conversation
Values read from database are not rounded, while written ones go through `float_round`, which may return a value differing by one unit in the last place (0.1 -> 0.09999999999999999). Comparing them with `!=` reported a change on every write of an unchanged value, and the raw value was then displayed as is. Compare and display float and monetary fields at their own precision.
Contributor
|
Hi @sebastienbeau, @Kev-Roche, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Values read from database are not rounded, while written ones go through
float_round, which may return a value differing by one unit in the last place (0.1 -> 0.09999999999999999). Comparing them with!=reported a change on every write of an unchanged value, and the raw value was then displayed as is. Compare and display float and monetary fields at their own precision.