Repository navigation
[20.0][MIG] vault_share: Migration to 20.0 - #1056
Open
CarlosRoca13 wants to merge 18 commits into
Open
CarlosRoca13 wants to merge 18 commits into
CarlosRoca13 wants to merge 18 commits into
Conversation
Fix website in manifest Run pre-commit Move models to own files. Apply OCA conventions Add application icon
…lect all possible users due to access rights - Disable the features if browser isn't using a secure context (https/localhost) - Load required assets in inbox and share frontends - Allow the user to switch a parent of an entry within the same vault - Allow to create entries for vaults using the main menu Entries - Fix bug that encrypted a share twice due to multiple extension with VaultAbstract - Fix a bug on share create that throws a warning about changed values
Currently translated at 87.2% (41 of 47 strings) Translation: server-auth-15.0/server-auth-15.0-vault_share Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-vault_share/es/
With the changes introduced on odoo/odoo@a251b14#diff-99de14b6e0a411718ac3adaaf779395155841c7ca9d95fa258369656dae63d18 the tests of vault and vault_share are failing.
To show the button up, it is requiring a getter that is not defined on vault field. So the getter is added and make the button works correctly. Steps to reproduce the problem: 1. Go to Vault 2. Enter/Create a Vault 3. Press on entries 4. Access/Create a entry with a field The button with external link is not showed
Accessing a share link (/vault/share/<token>) raised KeyError: 'website' when the website module is installed.
The server stored a different token than the one the form used to build the share link, which then always resulted in 'Invalid token'. The root cause was the token default returning a raw UUID object instead of a string. Use a str(uuid4()) default (readonly, copy=False) so every record gets a stable token and the UI/DB always agree.
|
All commit authors signed the Contributor License Agreement. |
Member
|
/ocabot migration vault_share |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT65357
This PR depends of:
ping @victoralmau @eduezerouali-tecnativa