Repository navigation
[FIX] queue_job: notify managers holding the group through implication - #986
Merged
OCA-git-bot merged 1 commit intoOct 26, 2026
Conversation
In Odoo 19 res.users.group_ids only holds explicitly assigned groups; implied ones are exposed through all_group_ids. Users who got Job Queue Manager through another group were no longer subscribed to failed jobs.
Contributor
amh-mw
approved these changes
Sep 21, 2026
ivantodorovich
approved these changes
Oct 22, 2026
Contributor
|
This PR has the |
guewen
approved these changes
Oct 26, 2026
Member
|
/ocabot merge patch |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
It looks like something changed on |
Contributor
|
Congratulations, your PR was merged at 9618c2e. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Odoo 19 res.users.group_ids only holds explicitly assigned groups; implied ones are exposed through all_group_ids. Users who got Job Queue Manager through another group were no longer subscribed to failed jobs.
_subscribe_users_domainsearched[("group_ids", "=", group.id)]. In Odoo 19res.users.group_idsonly holds explicitly assigned groups; implied groups are exposed throughall_group_ids(searched asgroup_ids.all_implied_ids).As a result, users who get Job Queue Manager through another group were no longer subscribed to failed jobs. The domain now uses
[("all_group_ids", "in", group.ids)].Added a test with a direct manager and a manager through an implying group; it fails on the current 19.0 branch.