Repository navigation
Conversation
baimont
force-pushed
the
bai_allow_commit_queue_job_cron
branch
from
August 14, 2026 10:05
cceac53 to
2c31cdb
Compare
Contributor
Author
|
take a look, @sbidoul ? |
sbidoul
reviewed
Oct 28, 2026
Comment on lines
+61
to
+63
| new_env = self.env(cr=new_cr) | ||
| server_action.with_env(new_env).run() | ||
| return True |
Member
There was a problem hiding this comment.
Suggested change
| new_env = self.env(cr=new_cr) | |
| server_action.with_env(new_env).run() | |
| return True | |
| return server_action.with_env(self.env(cr=new_cr) | |
| ).run() |
sbidoul
reviewed
Oct 28, 2026
sbidoul
left a comment
sbidoul
left a comment
Member
There was a problem hiding this comment.
I don't why the return is there but let's return the same thing in both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #899
Works as the new option on the job function but on the cron, false by default, allow to run the job in a new transaction