Repository navigation
Conversation
Contributor
guewen
approved these changes
Oct 26, 2026
And rename test module to remove typo.
florentx
force-pushed
the
19.0-queue_job-cursor_closing
branch
from
October 26, 2026 14:29
410d1ef to
84847b1
Compare
ivantodorovich
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant closing() wrapper
psycopg2will automatically close cursor when leaving thewith ...block. Since 2.5 (and Odoo depends on psycopg2 > 2.7 for more than 10 years now. https://github.com/odoo/odoo/blob/8.0/requirements.txt#L22 )And rename test module to remove typo.