[19.0][MIG] account_invoice_margin: Migration to 19.0 by Debora7 · Pull Request #254 · OCA/margin-analysis

Debora7 · 2026-01-08T10:52:41Z

No description provided.

[UPD] README.rst [UPD] Update account_invoice_margin.pot Translated using Weblate (Spanish) Currently translated at 100.0% (7 of 7 strings) Translation: margin-analysis-11.0/margin-analysis-11.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-11-0/margin-analysis-11-0-account_invoice_margin/es/

[UPD] README.rst

…t invoice margin security group set

[FIX] account_invoice_margin: Set purchase_price when user has not set invoice margin security group set

[REF] rename file with the name of the model [ADD] margins on account.invoice model (and related views) [ADD] description and screenshot [FIX] Typo on margin (%) field name [ADD] fr translation

…ual ones

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-12.0/margin-analysis-12.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-12-0/margin-analysis-12-0-account_invoice_margin/

… payments

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin/

Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-13.0/margin-analysis-13.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-13-0/margin-analysis-13-0-account_invoice_margin/es/

TT29471

Currently translated at 100.0% (9 of 9 strings) Translation: margin-analysis-17.0/margin-analysis-17.0-account_invoice_margin Translate-URL: https://translation.odoo-community.org/projects/margin-analysis-17-0/margin-analysis-17-0-account_invoice_margin/it/

Reyes4711-S73 · 2026-01-08T15:20:56Z

@Debora7 Please, solve pre-commit issues

Reyes4711-S73 · 2026-01-08T15:36:08Z

+            invoice.margin = margin
+            invoice.margin_signed = margin_signed
+            invoice.margin_percent = (
+                price_subtotal and margin_signed / price_subtotal * 100 or 0.0
+            )


Suggested change

invoice.margin = margin

invoice.margin_signed = margin_signed

invoice.margin_percent = (

price_subtotal and margin_signed / price_subtotal * 100 or 0.0

)

invoice.update(

{

"margin": margin,

"margin_signed": margin_signed,

"margin_percent": (

price_subtotal and margin_signed / price_subtotal * 100 if price_subtotal

else 0.0

)

}

)

Why is using as update() better?
It there a commendation to use that for computed field ?

@dreispt With this way you make only one query in DB.

Field writes are in memory, they don't trigger a DB query on their own.
And I'm not sure update is a public API; AFAICT it is not documented as such.

Reyes4711-S73 · 2026-01-15T12:06:39Z

ping @Debora7

Yusuke1998 · 2026-01-15T14:37:07Z

ping @Debora7

ping @Debora7

Reyes4711-S73 · 2026-01-15T15:39:16Z

@Debora7 Please, do the changes I recommeded you.
In addition, please squash pre-commit issues commit with the migration commit

dreispt

LGTM but please squash the extra fixes commit

Reyes4711-S73 · 2026-02-16T09:16:21Z

ping @Debora7

Fixed pre-commit issues.

dannyadair

Please don't remove checks from .pylintrc
It is repo-wide. If checks fail you need to fix the code not remove the test.

If .pylintrc needs to be adjusted it should be in a separate PR, not a module migration.

alexeirivera87 · 2026-03-16T13:48:09Z

Hello @Debora7

There is an error coming from this:

<record id="group_account_invoice_margin_security" model="res.groups"> <field name="name">Show Invoice Margin</field> <field name="privilege_id" ref="base.module_category_hidden" /> <field name="user_ids" eval="[(4, ref('base.user_admin'))]" /> </record>

Could you please check it? thanks

Alexis-SDK · 2026-04-13T08:43:50Z

Any news here, please?

Other MRs are blocked because of this one

dannyadair · 2026-04-14T21:16:07Z

don't change the repo-wide .pylintrc in a module migration. Especially don't change from v19 down to v18

(see output of pre-commit test "Run precommit" step)

That should have probably failed the test instead of just giving a warning.

dannyadair · 2026-04-14T21:23:52Z

@Debora7 in practical terms, just don't touch .pylintrc it's already ready for v19 https://github.com/OCA/margin-analysis/blob/19.0/.pylintrc
If you get pre-commit warnings/errors fix them, don't disable checks

Yusuke1998 · 2026-04-20T15:21:59Z

In the module's description/information, the paths to the images account_invoice_margin/static/description/account_invoice_tree.png and account_invoice_margin/static/description/account_invoice_form.png still need to be corrected.

sergio-teruel and others added 30 commits January 8, 2026 09:33

[9.0][WIP] account_invoice_margin: New module

d441f0e

[MIG] account_invoice_margin: Migration to v11

db69e3c

[11.0][IMP] account_invoice_margin: Minor fix in the same PR

e4362d1

[UPD] README.rst

[FIX] account_invoice_margin: Set purchase_price when user has not se…

050a499

…t invoice margin security group set

account_invoice_margin 11.0.1.1.0

97dd484

[MIG] account_invoice_margin: Migration to v12.0

02aedcd

[FIX] account_invoice_margin: Set purchase_price when user has not set invoice margin security group set

[UPD] Update account_invoice_margin.pot

aa991f4

[IMP] make purchase price computation overloadable

c878d1d

[REF] rename file with the name of the model [ADD] margins on account.invoice model (and related views) [ADD] description and screenshot [FIX] Typo on margin (%) field name [ADD] fr translation

[IMP] account_invoice_margin: margins computed with read_group + virt…

f7962a1

…ual ones

[IMP] move demo data for group, in data folder

ff42b6f

[UPD] Update account_invoice_margin.pot

f201992

account_invoice_margin 12.0.2.0.0

b590282

[IMP] account_invoice_margin: black, isort

47dbbae

[MIG] account_invoice_margin: Migration to v13.0

f3f16ae

[IMP] account_invoice_margin: Take on account invoice lines with down…

4dae328

… payments

[UPD] Update account_invoice_margin.pot

5627b9a

[ADD] generic method for better inheritance

2deaebd

[IMP] skip margin calculation for Down Payment invoice

c17a983

[UPD] README.rst

b1155a7

account_invoice_margin 13.0.1.0.1

5cc6c00

[13.0][IMP] account_invoice_margin: black, isort, prettier

ca86665

[14.0][MIG] account_invoice_margin: Migration to 14.0

a883575

[IMP] account_invoice_margin: Do optional fields in tree view

54762f0

TT29471

[UPD] Update account_invoice_margin.pot

600830a

[UPD] README.rst

0df9d99

mymage and others added 5 commits January 8, 2026 09:33

[IMP] account_invoice_margin: pre-commit auto fixes

ae5ee87

[MIG] account_invoice_margin: Migration to 18.0

6bce4c5

[UPD] Update account_invoice_margin.pot

d75b937

[BOT] post-merge updates

4a09012

Reyes4711-S73 reviewed Jan 8, 2026

View reviewed changes

dreispt reviewed Feb 16, 2026

View reviewed changes

Comment thread account_invoice_margin/tests/test_account_invoice_margin.py Outdated

[MIG] account_invoice_margin: Migration to 19.0

106a470

Fixed pre-commit issues.

Debora7 force-pushed the 19.0-mig-account-invoice-margin branch from f2ba90b to 106a470 Compare February 16, 2026 09:21

Delet commented code.

a8ef1b5

Fixed pre-commit issues.

Debora7 force-pushed the 19.0-mig-account-invoice-margin branch from 712e2f3 to a8ef1b5 Compare February 16, 2026 09:24

eugenios73 mentioned this pull request Mar 2, 2026

[19.0] [MIG] account_invoice_margin_sale superseed #258

Open

gdgellatly reviewed Mar 3, 2026

View reviewed changes

Comment thread .pylintrc

stferraro approved these changes Mar 3, 2026

View reviewed changes

dannyadair suggested changes Mar 5, 2026

View reviewed changes

Added back the pylint checks.

6703292

debora-artificially added 3 commits April 13, 2026 12:02

Fixed security xml.

e8f2989

pre commit fixes.

cf462b9

removed category_id.

dcdaa6b

Yusuke1998 mentioned this pull request Apr 20, 2026

Migration to version 19.0 #249

Open

7 tasks

-            invoice.margin = margin
-            invoice.margin_signed = margin_signed
-            invoice.margin_percent = (
-                price_subtotal and margin_signed / price_subtotal * 100 or 0.0
-            )
+            invoice.update(
+                {
+                    "margin": margin,
+                    "margin_signed": margin_signed,
+                    "margin_percent": (
+                        price_subtotal and margin_signed / price_subtotal  * 100 if price_subtotal
+                        else 0.0
+                    )
+                }
+            )

Uh oh!

Conversation

Debora7 commented Jan 8, 2026

Uh oh!

Reyes4711-S73 commented Jan 8, 2026

Uh oh!

Reyes4711-S73 Jan 8, 2026

Choose a reason for hiding this comment

Uh oh!

dreispt Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reyes4711-S73 Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

dreispt Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reyes4711-S73 commented Jan 15, 2026

Uh oh!

Yusuke1998 commented Jan 15, 2026

Uh oh!

Reyes4711-S73 commented Jan 15, 2026

Uh oh!

dreispt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reyes4711-S73 commented Feb 16, 2026

Uh oh!

Uh oh!

dannyadair left a comment

Choose a reason for hiding this comment

Uh oh!

alexeirivera87 commented Mar 16, 2026

Uh oh!

Alexis-SDK commented Apr 13, 2026

Uh oh!

dannyadair commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannyadair commented Apr 14, 2026

Uh oh!

Yusuke1998 commented Apr 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

dannyadair commented Apr 14, 2026 •

edited

Loading