[18.0][FIX] enable document reference link generation#609
[18.0][FIX] enable document reference link generation#609OCA-git-bot merged 1 commit intoOCA:18.0from
Conversation
|
Hi @etobella, |
OCA-git-bot
added
series:18.0
mod:document_page_reference
|
TEsts are failing and use a proper commit description |
KDRdev
changed the title
KDRdev
changed the title
KDRdev
force-pushed
the
18.0-fix_document_page_reference_link
branch
from
481ab4f to
9dc26a2
Compare
|
@etobella Tests have been fixed |
KDRdev
changed the title
KDRdev
force-pushed
the
18.0-fix_document_page_reference_link
branch
from
9dc26a2 to
d1f40cf
Compare
| self.page1.content = Markup("<p></p>") | ||
| self.assertEqual(self.page1.content_parsed, Markup("<p></p>")) | ||
| self.page1.content = Markup("<p>{{r2}}</p>") | ||
| self.page1._compute_content_parsed() |
There was a problem hiding this comment.
You shouldn't need to execute compute functions
There was a problem hiding this comment.
You're right. Will remove unnecessary lines
|
|
||
|
|
||
| class TestDocumentReference(BaseCommon): | ||
| class TestDocumentReference(TransactionCase): |
There was a problem hiding this comment.
Why did you change it back to Transactioncase? wasn't BaseCommon working?
There was a problem hiding this comment.
Yes, I was getting not-null constraint error: null value in column "autopost_bills" of relation "res_partner" violates not-null constraint when using BaseCommon. With TransactionCase it works.
There was a problem hiding this comment.
That probably happens because you installed several modules and this was providing a problem with that. LEave it as it was please 🙏
There was a problem hiding this comment.
Changed this back to BaseCommon. Thank you
Before this change, adding reference to another document with {{SOME_REF}} won't transform this to a link as described in README. Now after saving the document with valid reference, it will be shown as a link to related document.
KDRdev
force-pushed
the
18.0-fix_document_page_reference_link
branch
from
d1f40cf to
043e37c
Compare
|
I tested the latest commit successfully. |
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at f428b8f. Thanks a lot for contributing to OCA. ❤️ |
Currently, the document PDF report outputs raw HTML. This fix returns functionality which was used before merging PR OCA#609 and aims to resolve report generation issues. fix page printing of HTML code
Currently, the document PDF report outputs raw HTML. This fix returns functionality which was used before merging PR OCA#609 and aims to resolve report generation issues.
5 participants
Currently referencing other documents with {{SOME_REF}} won't result in showing this as a link.
This PR addresses with issue and allows showing link after saving the document.