Repository navigation
[13.0] [OU-FIX] product: archive duplicated variants - #6070
Merged
pedrobaeza merged 1 commit intoOct 29, 2026
Merged
Conversation
Before odoo/odoo@088edee2ce71 ("[FIX] product: do not create duplicate variants", odoo/odoo#35013), Odoo 12 reactivated archived variants whose combination already had an active variant (sell the variants, remove an attribute from the template, add it again). That fix prevents new duplicates but doesn't clean the existing ones, so v12 databases can contain several active variants for the same combination, and the creation of the product_product_combination_unique index on v13 fails. Variants without attribute values get an empty combination_indices, as Odoo computes it, so they are also covered. For each template and combination, the variant with the lowest ID is kept active and the others are archived: unlike OCA#2513, no records are merged or deleted. Assisted-by: Claude Opus 5.5
Contributor
|
That's an interesting approach, an alternative to my old PR. |
pedrobaeza
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before odoo/odoo@088edee2ce71 ("[FIX] product: do not create duplicate variants", odoo/odoo#35013), Odoo 12 reactivated archived variants whose combination already had an active variant (sell the variants, remove an attribute from the template, add it again). That fix prevents new duplicates but doesn't clean the existing ones, so v12 databases can contain several active variants for the same combination, and the creation of the product_product_combination_unique index on v13 fails.
Variants without attribute values get an empty combination_indices, as Odoo computes it, so they are also covered. For each template and combination, the variant with the lowest ID is kept active and the others are archived: unlike #2513, no records are merged or deleted.