Skip to content

[19.0][FIX] stock_account: don't create missing accounts from the chart template #6067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JordiBForgeFlow wants to merge 1 commit into from
Closed

[19.0][FIX] stock_account: don't create missing accounts from the chart template #6067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion openupgrade_scripts/scripts/stock_account/19.0.1.1/end-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,15 @@ def ref_or_id(ref_or_id, model_name, AccountChartTemplate=AccountChartTemplate):
for record_id, record_data in template_data[model_name].items():
if not any(record_data.get(key) for key in field_names):
continue
record = ref_or_id(record_id, model_name)
if not record:
# only complete existing records, _load_data would create
# the missing ones with just the fields in spec
continue
filtered = {
key: value
for key, value in record_data.items()
if key in field_names and not ref_or_id(record_id, model_name)[key]
if key in field_names and not record[key]
}
if filtered:
filtered_records[record_id] = filtered
Expand Down
Loading