Skip to content

Fix UI freezes and snapshot deadlocks in Tao application scope #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DatL4g wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix UI freezes and snapshot deadlocks in Tao application scope #430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67ac527
improve performance, prevent freezes and deadlocks
DatL4g Aug 3, 2026
024faa2
Merge branch 'main' into main
DatL4g Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ...rated-window-tao/src/main/kotlin/dev/nucleusframework/window/tao/TaoApplicationCompose.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import androidx.compose.ui.platform.LocalLayoutDirection
import dev.nucleusframework.window.tao.dispatch.TaoMainDispatcher
import dev.nucleusframework.window.tao.ffi.NativeTaoBridge
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Job
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.channels.Channel
import kotlinx.coroutines.flow.consumeAsFlow
import kotlinx.coroutines.flow.first
Expand Down Expand Up @@ -55,7 +55,7 @@ public fun taoApplication(content: @Composable ApplicationScope.() -> Unit) {
// loop and runs at the next `MainEventsCleared` pump tick.
val coroutineScope =
CoroutineScope(
TaoMainDispatcher + TaoFrameClock + Job(),
TaoMainDispatcher + TaoFrameClock + SupervisorJob(),
)

// Snapshot apply observer: forwards state writes from any thread back
Expand Down Expand Up @@ -117,12 +117,17 @@ private val snapshotStarted = AtomicBoolean(false)

private fun startGlobalSnapshotManager(scope: CoroutineScope) {
if (!snapshotStarted.compareAndSet(false, true)) return
val channel = Channel<Unit>(1)
val channel = Channel<Unit>(Channel.CONFLATED)
val sent = AtomicBoolean(false)
scope.launch {
channel.consumeAsFlow().collect {
sent.set(false)
Snapshot.sendApplyNotifications()
try {
Snapshot.sendApplyNotifications()
} catch (ignored: Throwable) {
// catch and ignore runtime errors to prevent application deadlock
} finally {
sent.set(false)
}
}
}
Snapshot.registerGlobalWriteObserver {
Expand Down
Loading