build: target Compose Multiplatform 1.12.0-rc01 - #428
Open
kdroidFilter wants to merge 1 commit into
Open
Conversation
Skiko 0.150.1 changed Image.encodeToData to take an extra pngCompressionLevel parameter, so the 1.11-compiled artifacts fail at runtime with NoSuchMethodError on apps running Compose 1.12. Source stays compatible; only a recompile against 1.12 is required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Apps running Compose Multiplatform 1.12 crash on the current artifacts:
Skiko 0.150.1 (shipped with Compose 1.12) added a
pngCompressionLevelparameter toImage.encodeToData, so the synthetic$defaultbridge we were compiled against no longer exists.The call site is source-compatible (all extra params have defaults) — only a recompile against 1.12
is needed.
Change
compose1.11.1 → 1.12.0-rc01 (skiko 0.150.1)No source changes were required in
composenativetrayorcomposenativetray-app.Verified
./gradlew build(compile + tests + ktlint + detekt) green on both modules:demo:compileKotlinJvmgreenNote
Downstream,
nucleus.decorated-window-tao2.4.4 is still compiled against Compose 1.11 and failswith a matching
NoSuchMethodErroronCanvasLayersComposeScene, so a Nucleus release builtagainst 1.12 is required before the demo/TrayApp path works end to end. Nothing to fix here.
When 1.12.0 stable ships, this is a one-line version bump.