Repository navigation
feat(pets): hand-drawn left walks for the ghost and the robot - #55
Merged
Merged
Conversation
Mirroring the right walk flipped their top-left light. The left walks keep highlights on the left and shade on the right, lean and look left, and trail the ghost's wisps and the robot's dust and antenna to the right. Same frames, timings and exits as walk, dx -1, head anchors moved to the left-facing body. Signed-off-by: NovusEdge <novusedge0@gmail.com>
Same frames, timings and exits as pant-walk, dx -1, head anchors moved to the left-facing body. The light stays top-left; the ghost's sweat drop and the robot's drooping antenna lead to the left, and the wisps, steam and sweat trail to the right. Signed-off-by: NovusEdge <novusedge0@gmail.com>
Signed-off-by: NovusEdge <novusedge0@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe ghost and CRT gain hand-drawn left-facing walk and pant-walk animations in their art assets and sprite sheets. Tests check that both animations exist and use leftward movement. The changelog records the update. ChangesLeft-walk animations
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: adding hand-drawn left-walking animations for the ghost and robot pets. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit sketches leftward feet,
Four-frame steps and panting beats.
Ghost and CRT now turn,
While pixels trace each stride and curve.
Tests confirm the leftward way,
And changelog notes the art today.
Comment @coderabbitai help to get the list of available commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ghost and the robot had only right walks, mirrored when walking left. Both are lit from the top left, so the mirror put their light on the wrong side. This adds hand-drawn
walk-leftandpant-walk-leftfor both, as Clawd has.check_distinct.pypasses for both;claude plugin test .passes (1218).Summary by CodeRabbit