Fix/web audio resume after reopen - #225
Merged
m-abs merged 2 commits intoSep 11, 2026
Merged
Conversation
audioEnable fired its restore seek without awaiting it, so the promise resolved immediately and Dart's follow-up play() landed while upstream AudioNavigator.go() still had _isNavigating true. Readium's DOM "play" handler is guarded by that flag, so the event was swallowed: audio ran but position polling never restarted and the player reported paused until the track ended. Await the seek in both "navigator already exists" branches so audioEnable resolves only once navigation has finished. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
flutter drive hardcodes the WebDriver capability goog:loggingPrefs.browser to INFO and offers no flag to change it, so chromedriver discards every console.debug entry before the test driver reads the browser log. A log.debug added while investigating a failure therefore looks like code that never ran. Detect navigator.webdriver and route debug output through console.log under WebDriver, keeping console.debug (and the DevTools "Verbose" filter) in a normal browser. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.