Skip to content

languages/angular: fix server name in the typescript filetype merge - #1816

Open
Marcus441 wants to merge 2 commits into
NotAShelf:mainfrom
Marcus441:main
Open

languages/angular: fix server name in the typescript filetype merge#1816
Marcus441 wants to merge 2 commits into
NotAShelf:mainfrom
Marcus441:main

Conversation

@Marcus441

Copy link
Copy Markdown

The second vim.lsp.servers definition spells the server "angular-language-serve", so enabling languages.angular.lsp registers a phantom server of that name with filetypes = ["typescript"] and no cmd, adds it to vim.lsp.enable, and never gives the real angular-language-server the typescript filetype it was meant to get.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

🚀 Live preview deployed from 4771b6b

View it here:

Debug Information

Triggered by: horriblename

HEAD at: main

Reruns: 4054

@NotAShelf
NotAShelf enabled auto-merge (rebase) September 8, 2026 11:11
github-actions Bot pushed a commit that referenced this pull request Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants