Skip to content

plugins/lualine: fix duplicate diagnostic data - #1813

Merged
NotAShelf merged 7 commits into
NotAShelf:mainfrom
horriblename:lualine-fix-double-dia
Sep 4, 2026
Merged

plugins/lualine: fix duplicate diagnostic data#1813
NotAShelf merged 7 commits into
NotAShelf:mainfrom
horriblename:lualine-fix-double-dia

Conversation

@horriblename

@horriblename horriblename commented Sep 3, 2026

Copy link
Copy Markdown
Collaborator

closes #1810 and #1801

thanks @alexperreault

fully migrates lualine to setupOpts. Gets rid of option definitions that aren't that important. On the point of #1801, the theme names are "catppuccin-mocha" etc and not "catppuccin". I don't think there's any need to add more nix code to handle that, "auto" works just fine.

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

🚀 Live preview deployed from f33afa7

View it here:

Debug Information

Triggered by: horriblename

HEAD at: lualine-fix-double-dia

Reruns: 4045

@horriblename
horriblename force-pushed the lualine-fix-double-dia branch from 01cac0b to 70f1eef Compare September 3, 2026 22:21
@alexperreault

Copy link
Copy Markdown

Tested on aarch64-darwin, works.

Thanks!

@horriblename
horriblename force-pushed the lualine-fix-double-dia branch from 13a6d16 to cb84762 Compare September 4, 2026 00:46
github-actions Bot pushed a commit that referenced this pull request Sep 4, 2026
github-actions Bot pushed a commit that referenced this pull request Sep 4, 2026
@NotAShelf
NotAShelf merged commit 5e4f212 into NotAShelf:main Sep 4, 2026
14 of 15 checks passed
@horriblename
horriblename deleted the lualine-fix-double-dia branch September 4, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: lsp warnings are counted double in lualine

3 participants