Conversation
horriblename
left a comment
horriblename
left a comment
There was a problem hiding this comment.
Why not just split up supported-themes.nix into their own files, and have them define their options like normal modules?
# modules/plugins/theme/onedark.nix
{lib, config, ...}: {
options = {
enable = lib.mkEnableOption "...";
setupOpts = ...;
}
config.vim = {
startPlugins = ["onedark"];
luaConfigRC = "require'onedark'.setup(${...})";
};
}lazy-loading colorschemes is probably desirable since we're allowing multiple colorschemes
horriblename
left a comment
horriblename
left a comment
There was a problem hiding this comment.
I changed my mind about splitting supporthed-themes.nix, I'll accept this aside from the "what" in the warnings section
(API looks good we'll just refactor later only if it starts being a problem)
|
|
||
| # We'd like to warn when the user is using a completely legacy configuration | ||
| warnings = let | ||
| # FIXME: what |
snoweuph
left a comment
snoweuph
left a comment
There was a problem hiding this comment.
Please add some Changelog info about the stuff you're doing here.
8edc00c to
92aac8c
Compare
92aac8c to
310442a
Compare
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Ia2fc674a2b2fb199443b9c6985029e426a6a6964
310442a to
946ad52
Compare
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: Ib540b435f6dbbcea2cdfebfdf1c65f6b6a6a6964
Signed-off-by: NotAShelf <raf@notashelf.dev> Change-Id: I7615b80b1ea23bfad04e44c718a666436a6a6964
| ... | ||
| }: '' | ||
| setup = setupOpts: let | ||
| cleanedOpts = |
There was a problem hiding this comment.
should there be some way for users to do config on here?
| cleanedOpts = | ||
| (removeAttrs setupOpts ["style" "transparent"]) | ||
| // { | ||
| dark_variant = setupOpts.style or "main"; # main, moon, or dawn |
There was a problem hiding this comment.
is that comment realy needed anymore when styles is literary defined as those 3 already.
| (removeAttrs setupOpts ["transparent"]) | ||
| // { | ||
| transparent = setupOpts.transparent or false; | ||
| search = "vscode"; # [vim|vscode] |
There was a problem hiding this comment.
why is it vscode and not vim? also why the comment, when there is no way to configure and its hardcoded?
thould this maybe get some way for a user to configure?
7 participants
This is all @faukah's fault. I blame him for everything.
This PR finally refactors the theming module to be more configurable, namely in the sense that it can now:
setupOptsAPI that we've been pushingIn the light of the new API, the old options have been soft-deprecated. I would like to remove them altogether but I ran into some stupid issues with the warning messages, and could not be bothered with fixing each one of them one by one. Eventually we'll want to figure it out. Eventually.
Needs documentaton, and should be merged preferably after #1160 so we don't create more 9-sided merge conflicts.