Repository navigation
fix: stop the report form offering None, which GitHub reserves - #27
Merged
Merged
Conversation
GitHub refuses to render an issue form whose dropdowns offer "None", since it writes that itself for a dropdown left blank. Play Integrity and Widevine both did, so the report form wouldn't open. - Play Integrity's lowest value is now `fails`, and Widevine's `unsupported`, in features.yml, the form, the contributing guide and the test fixtures. No device or ROM data used the old value - A test checks the form's dropdowns match features.yml, and that none of them offers None Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Keeps both new tests at the end of tests/report.test.js, and updates the card view's wording test for Widevine's renamed value, "Likely unsupported". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Bugfix
Overview
Fixes the issue form
Issue Number
N/A