Repository navigation
Conversation
Checked against lines recorded from the official server (a character with four pets and two partners), now pinned in OfficialMatePacketTests: - sc_p has 40 fields, not 33: Unknow2..Unknow8 (34 is 1-3 per pet, 39 is always 1). With only 33 fields the client's pet window shows no pictures. - sc_n ends with two more fields (Unknown4, Unknown5). - in: the non-player part ends with two more fields for monsters, npcs and mates alike (Unknow7 carries the pet's 1-3 value, 0 otherwise). - ptctl is typed: Mates (id, x, y per mate, counted by Amount), then VisualId and Speed. Breaking: PacketEnd is gone. - An absent sub-packet written with its own separator keeps its leading space, so a partner without equipment is "sc_n ... 13458 -1 -1 -1 -1", not "13458-1-1-1-1". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe packet models now include additional mate and spawn fields. The ChangesMate packet formats
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 8 files. (2 skipped: 2 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly identifies the breaking 22.0.0 update and accurately summarizes the main change: matching mate packet formats to the official server. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 8 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Fix all pre-merge checks with AI
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
1 participant
Brings the pet/partner packets in line with what the official server sends, for the pets work in NosCore (#655).
Changes
sc_p: 40 fields instead of 33. NewUnknow2..Unknow8(indexes 33-39). In the recordings, 34 is 1, 2 or 3 depending on the pet and 39 is always 1. With only 33 fields the client's pet window shows no pictures.sc_n: two more trailing fields (Unknown4,Unknown5; the second is 0 or 1 depending on the partner).in: two more trailing fields on the non-player part (Unknow7,Unknow8). The official server sends them for monsters, npcs and mates alike (30 tokens; we sent 28).Unknow7carries the pet's 1-3 value, 0 for partners, npcs and monsters.ptctlis typed:Mates(onePtctlSubPacketper mate: id, x, y; counted byAmount, likerest), thenVisualIdandSpeed. With two mates out:ptctl 1 2 1135623 50 132 1135626 49 133 1135623 9. The trailing id and speed were the first mate's in every recording.Breaking:
PacketEndis removed, hence 22.0.0. NosCore does not use it.sc_n ... 13458-1-1-1-1instead of13458 -1 -1 -1 -1.How it was checked
OfficialMatePacketTestsbuildssc_p,sc_nandin(pet and monster) from those values and compares with the recorded lines character for character, and reads a recorded two-mateptctl.sc_p,sc_n,inandptctllines changed. The two existinginexpectations inSerializerTestgain the two trailing zeros.Not yet checked
That the 40-field
sc_pbrings the pet window pictures back in the client. I'll confirm that in-game with the NosCore change that uses this release.🤖 Generated with Claude Code
Summary by CodeRabbit