Skip to content

bookorbit: 2.8.1 -> 2.9.0 - #560883

Merged
nixpkgs-ci[bot] merged 1 commit into
NixOS:masterfrom
helsinki-systems:upd/bookorbit
Sep 7, 2026
Merged

nixpkgs-ci[bot] merged 1 commit into
NixOS:masterfrom
helsinki-systems:upd/bookorbit

Conversation

@dasJ

@dasJ dasJ commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

Things done

@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Sep 7, 2026
@nixpkgs-ci
nixpkgs-ci Bot requested a review from iv-nn September 7, 2026 13:03
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 7, 2026
@iv-nn

iv-nn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

I could not fully test the new requests feature because my download client is not supported, the indexer works at least. Did you try it?

@dasJ

dasJ commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

I have honestly not checked but the changelog looked innocent enough.

@dstengele do you have time to have a look?

@iv-nn

iv-nn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

I doubt the download client would be an issue but it would be nice to test. One thing that could be an issue is the new plugin system to add indexers. I have not found any plugin to try but I've not looked into it very deeply yet.

@iv-nn

iv-nn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

OK, plugins works. The indexers need a new env var BOOK_REQUEST_ENCRYPTION_KEY to be added but I don't think it should be added to the module. If someone manage to test the download client integration feel free to comment here.

@iv-nn

iv-nn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci
nixpkgs-ci Bot added this pull request to the merge queue Sep 7, 2026
@nixpkgs-ci

nixpkgs-ci Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@iv-nn wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ✅ PR is at least one of:
  • ✅ PR is not a draft
  • ✅ PR is not blocked by a "changes requested" review from a committer.
  • ✅ iv-nn is a member of @NixOS/nixpkgs-maintainers.
  • ✅ iv-nn is a maintainer of all touched packages on the master branch.

✔️ Queued for merge (#306934)

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Sep 7, 2026
Merged via the queue into NixOS:master with commit a5d3101 Sep 7, 2026
36 checks passed
@dasJ
dasJ deleted the upd/bookorbit branch September 7, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants