Repository navigation
Drop unused futures-core dev-dependency from lspkit-server - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Removes the one unused dependency found by a sweep across every crate, the npm package and the .NET projects.
Changed/Deleted
crates/lspkit-server/Cargo.toml: delete thefutures-coredev-dependency. No lspkit-server test importsfutures_core.Sweep results (no change needed)
cargo machetealso flaggedstats_allocin lspkit and lspkit-server. That is a false positive: the heap-leak tests pull it in through#[path]-includedtest-support/state.rs.lsp-profiler-ui: every dependency is imported or used by the scripts and test runner (@vscode/test-electronis loaded at runtime by@vscode/test-cli, and@types/mochasupplies the suite globals).How tests prove it
cargo clippy -p lspkit-server --all-targets --all-features -D warningsand the test build pass. CI runs the full suite.Breaking changes
None.
🤖 Generated with Claude Code