Skip to content

Drop unused futures-core dev-dependency from lspkit-server - #63

Merged
MelbourneDeveloper merged 1 commit into
mainfrom
chore/remove-unused-deps
Nov 18, 2026
Merged

MelbourneDeveloper merged 1 commit into
mainfrom
chore/remove-unused-deps

Conversation

@MelbourneDeveloper

Copy link
Copy Markdown
Collaborator

TLDR

Removes the one unused dependency found by a sweep across every crate, the npm package and the .NET projects.

Changed/Deleted

  • crates/lspkit-server/Cargo.toml: delete the futures-core dev-dependency. No lspkit-server test imports futures_core.

Sweep results (no change needed)

  • cargo machete also flagged stats_alloc in lspkit and lspkit-server. That is a false positive: the heap-leak tests pull it in through #[path]-included test-support/state.rs.
  • lsp-profiler-ui: every dependency is imported or used by the scripts and test runner (@vscode/test-electron is loaded at runtime by @vscode/test-cli, and @types/mocha supplies the suite globals).
  • .NET: TraceEvent and NETCore.Client are both used directly by the engine, and the xunit packages by its tests.

How tests prove it

cargo clippy -p lspkit-server --all-targets --all-features -D warnings and the test build pass. CI runs the full suite.

Breaking changes

None.

🤖 Generated with Claude Code

@MelbourneDeveloper
MelbourneDeveloper merged commit 17b572e into main Nov 18, 2026
10 checks passed
@MelbourneDeveloper
MelbourneDeveloper deleted the chore/remove-unused-deps branch November 18, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant