Repository navigation
Dispose decoration types left behind by palette changes - #59
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a LOW item from the v0.6.0 leak review, which #56 wrongly judged bounded. Both decoration maps are keyed by colour, and the palette is re-read from settings on every render, so each palette change left the previous colours' decoration types allocated for the rest of the session.
Test first:
decoration-palette.test.tschanges thelspui.profiler.palettesetting 8 times and paints a hot line after each change. Before the fix it failed with9 decoration types allocated after 8 palette changes.Fix: a new
pruneToPalettedisposes the types whose colour the current palette no longer uses. It runs whenever a type for a new colour is created, in both the heat and the memory decorations.Verification:
npm run lintpasses; the VS Code UI suite (191), the teardown suite (1) and the unit tests (117) pass.