Skip to content

Release: make lspkit's tracing a dev-dependency; package crates in PR CI - #54

Merged
MelbourneDeveloper merged 1 commit into
mainfrom
fix/release-unused-deps
Nov 17, 2026
Merged

MelbourneDeveloper merged 1 commit into
mainfrom
fix/release-unused-deps

Conversation

@MelbourneDeveloper

Copy link
Copy Markdown
Collaborator

TLDR

The v0.6.0 release failed at cargo package: lspkit's tracing dependency is only used by its tests, so the denied unused_dependencies lint rejects the packaged crate. This moves it to [dev-dependencies], and PR CI now runs the same packaging step.

Changed

  • crates/lspkit/Cargo.toml: tracing moved from [dependencies] to [dev-dependencies], because only tests/sidecar_cancellation_session.rs logs with it.
  • Makefile build: runs cargo package --workspace --locked --allow-dirty, the exact step in release.yml, so a packaging failure shows up on the PR, not after the tag.

How tests prove it

  • Red: on main, make build fails with error: unused dependency 'tracing' / failed to verify package tarball, the same as release run 44185395808.
  • Green: with this change, cargo package --workspace builds all 4 crates from their tarballs, tests/sidecar_cancellation_session.rs passes 4/4, and clippy is clean.

Breaking changes

None. lspkit's library never used tracing.

🤖 Generated with Claude Code

@MelbourneDeveloper

Copy link
Copy Markdown
Collaborator Author

Review (lspkitClaudeFixes1): ✅

  • tracing → [dev-dependencies] matches its use: only tests/sidecar_cancellation_session.rs and tests/tracing_setup.rs import it, and include = ["src/**/*", ...] leaves tests out of the tarball. With the change, cargo package -p lspkit --locked passes locally.
  • make build → cargo package --workspace closes the gap that let Server-to-client requests (#48), JSON-RPC null params, red→green regressions for #21 #26 #49 #51 go green and then fail at release. It costs one extra package-verify build per CI run, which is worth it.
  • Remaining release-only risk: the version stamp (0.0.0-dev → 0.6.0) runs before packaging in release.yml, and CI doesn't exercise that order. Not blocking.

@MelbourneDeveloper
MelbourneDeveloper merged commit 8e39446 into main Nov 17, 2026
10 checks passed
@MelbourneDeveloper
MelbourneDeveloper deleted the fix/release-unused-deps branch November 17, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant