Repository navigation
Release: make lspkit's tracing a dev-dependency; package crates in PR CI - #54
Merged
Merged
Conversation
…e's cargo package so PR CI catches it
Collaborator
Author
|
Review (lspkitClaudeFixes1): ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The v0.6.0 release failed at
cargo package: lspkit'stracingdependency is only used by its tests, so the deniedunused_dependencieslint rejects the packaged crate. This moves it to[dev-dependencies], and PR CI now runs the same packaging step.Changed
crates/lspkit/Cargo.toml:tracingmoved from[dependencies]to[dev-dependencies], because onlytests/sidecar_cancellation_session.rslogs with it.Makefilebuild: runscargo package --workspace --locked --allow-dirty, the exact step inrelease.yml, so a packaging failure shows up on the PR, not after the tag.How tests prove it
main,make buildfails witherror: unused dependency 'tracing'/failed to verify package tarball, the same as release run 44185395808.cargo package --workspacebuilds all 4 crates from their tarballs,tests/sidecar_cancellation_session.rspasses 4/4, and clippy is clean.Breaking changes
None. lspkit's library never used
tracing.🤖 Generated with Claude Code