Skip to content

Fix integer overflow when reading from yaml #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptthanh02 merged 1 commit into from
Jun 1, 2026
+6 −5
Merged

Fix integer overflow when reading from yaml #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions core/src/main/java/github/nighter/smartspawner/spawner/data/SpawnerFileHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.io.File;
import java.io.IOException;
import java.math.BigInteger;
import java.util.*;
import java.util.concurrent.ConcurrentHashMap;
import java.util.logging.Logger;
Expand Down Expand Up @@ -380,7 +381,7 @@ private SpawnerData loadSpawnerFromConfig(String spawnerId, boolean logErrors, b
spawner.getSpawnerStop().set(Boolean.parseBoolean(settings[3]));
spawner.setSpawnDelay(parseClampedLong(settings[4], 1L, Long.MAX_VALUE));
spawner.setMaxSpawnerLootSlots(Integer.parseInt(settings[5]));
spawner.setMaxStoredExp(Integer.parseInt(settings[6]));
spawner.setMaxStoredExp(parseClampedLong(settings[6], 0L, Long.MAX_VALUE));
spawner.setMinMobs(Integer.parseInt(settings[7]));
spawner.setMaxMobs(Integer.parseInt(settings[8]));
// Load maxStackSize BEFORE stackSize so the saved limit is in place
Expand All @@ -398,7 +399,7 @@ private SpawnerData loadSpawnerFromConfig(String spawnerId, boolean logErrors, b
spawner.getSpawnerStop().set(Boolean.parseBoolean(settings[3]));
spawner.setSpawnDelay(parseClampedLong(settings[4], 1L, Long.MAX_VALUE));
spawner.setMaxSpawnerLootSlots(Integer.parseInt(settings[5]));
spawner.setMaxStoredExp(Integer.parseInt(settings[6]));
spawner.setMaxStoredExp(parseClampedLong(settings[6], 0L, Long.MAX_VALUE));
spawner.setMinMobs(Integer.parseInt(settings[7]));
spawner.setMaxMobs(Integer.parseInt(settings[8]));
spawner.setStackSize(parseClampedInt(settings[9], 1, Integer.MAX_VALUE), restartHopper);
Expand Down Expand Up @@ -553,9 +554,9 @@ private int parseClampedInt(String raw, int min, int max) {
}

private long parseClampedLong(String raw, long min, long max) {
java.math.BigInteger value = new java.math.BigInteger(raw);
java.math.BigInteger minValue = java.math.BigInteger.valueOf(min);
java.math.BigInteger maxValue = java.math.BigInteger.valueOf(max);
BigInteger value = new BigInteger(raw);
BigInteger minValue = BigInteger.valueOf(min);
BigInteger maxValue = BigInteger.valueOf(max);

if (value.compareTo(minValue) < 0) {
return min;
Expand Down
Loading