Issue #3615336: skip missing locale projects (Shrey Narayan, NextBrick) - #1
Open
NextbrickInc wants to merge 1 commit into
Open
Issue #3615336: skip missing locale projects (Shrey Narayan, NextBrick)#1NextbrickInc wants to merge 1 commit into
NextbrickInc wants to merge 1 commit into
Conversation
Stale project names in translation status data caused a TypeError when sourceBuild() received NULL. Skip untracked projects and return NULL from loadSource() so cron and batch jobs continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LocaleSource::sourceBuild()when a stale project name is still present in translation status data but no longer returned byLocaleProjectRepository(for example after a module is uninstalled).loadSources()now skips untracked projects,loadSource()returnsNULL, and locale batch/cron callers continue instead of fataling.Author: Shrey Narayan, NextBrick
Email: employeenextbrick@gmail.com
Upstream issue: https://www.drupal.org/project/drupal/issues/3615336
Test plan
LocaleSourceTest(core/modules/locale/tests/src/Unit/LocaleSourceTest.php).