Skip to content

Fix macOS CI failures - #719

Merged
CozySocksAlways merged 8 commits into
NeuralEnsemble:masterfrom
INM-6:fix/macbuild
Nov 11, 2026
Merged

CozySocksAlways merged 8 commits into
NeuralEnsemble:masterfrom
INM-6:fix/macbuild

Conversation

@CozySocksAlways

@CozySocksAlways CozySocksAlways commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Desc

Currently there are two issues with macOS CI pipeline

Exact floating point comparisons in unit tests breaking in macOS

  • Potentially numerical back-end in arm mac's causing this mismatch
  • Fix is to use allclose comparisons from numpy

macOS arm64 wheel build fails

  • libomp dependency does not satisfy target macOS version 15.0, as host runner is macOS 26.0
  • Fix is to use a custom runner rather than macos-latest, i.e. macos-15.0 so that host and target agree

@coveralls

coveralls commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 88.949% (+0.7%) from 88.224% — INM-6:fix/macbuild into NeuralEnsemble:master

@CozySocksAlways CozySocksAlways self-assigned this Oct 21, 2026

@CozySocksAlways CozySocksAlways left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trigger wheel build

@CozySocksAlways CozySocksAlways added this to the v1.3.0 milestone Nov 2, 2026
@CozySocksAlways CozySocksAlways mentioned this pull request Nov 3, 2026
4 tasks done

@mdenker mdenker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Commenting" now to see the result of the pipeline run. Left two comments to look at, otherwise looks great to me.

Comment thread elephant/test/test_spectral.py Resolved
Comment thread .github/workflows/build_wheels.yml Resolved
@CozySocksAlways
CozySocksAlways merged commit 4315e06 into NeuralEnsemble:master Nov 11, 2026
36 of 37 checks passed
@CozySocksAlways
CozySocksAlways deleted the fix/macbuild branch November 11, 2026 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants