Repository navigation
feat(ffi): sync src/ffi with Nethermind 1e5d1fa8a0 for native ABI 10 - #2
Merged
Merged
Conversation
Nethermind feature/eip8288-lean now requires ABI 10 (NethermindEth/nethermind@e1939b5da3 adds nlean_last_error), so the ABI 9 library this repo publishes fails the startup check of every EIP-8288 node. Apply the tools/lean-ffi changes from 39e7bff6ef to 1e5d1fa8a0, keeping this repo's MIT headers and paths, and move the smoke test, the package description and NETHERMIND_REVISION to ABI 10. The committed binaries still need a Build Lean run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@rubo this is the source half of the ABI 10 update; the rest needs you:
Locally, as |
rubo
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nethermind
feature/eip8288-leannow requires native ABI 10 (NethermindEth/nethermind@e1939b5da3 addsnlean_last_error), butsrc/ffiand the published0.1.0.8are ABI 9, so every EIP-8288 node using the package fails its startup check.This applies the
tools/lean-ffichanges from39e7bff6efto1e5d1fa8a0tosrc/ffi, keeping the MIT headers and paths, and moves the smoke test, package description andNETHERMIND_REVISIONto ABI 10.Needs a Build Lean run before Test / Publish can pass: the committed binaries are still ABI 9.