fix: standardise demo config filenames on config.txt - #70
Merged
Conversation
color-sharing failed on setup: it passed "demos/config" to llm:load-config, which resolves against the model's own directory first, so the lookup became demos/color-sharing/demos/config and never matched. Its own config.txt sat beside it, unused. Three naming conventions were in use across five demos — "config", "config.txt", and a path-prefixed form. config.txt is the majority convention, so the two extensionless files are renamed to match. The extensionless name is also the blocker on #61, where the baba-is-ai library submission was rejected over it. - rename demos/baba-is-ai/config and demos/provider-sensitivity/config to config.txt; update both models to load the new name - point color-sharing at config.txt instead of demos/config - track demos/color-sharing/config.txt, which existed locally but was never committed — a fresh clone got a broken demo even with the path fixed - add .gitignore negations for the three files so the config-*.txt secret-protection pattern from #42 does not swallow them All three configs carry placeholder keys or local Ollama endpoints; no secrets are added. Verified: all three models compile headless against NetLogo 7.0.3, and the config-resolution check that flagged color-sharing now passes. Closes #66.
The rename updated the model's llm:load-config call but left three user-facing references pointing at the old extensionless name. The Info tab reference matters most: it ships inside the .nlogox, and #61 is a Models Library re-submission that was rejected over exactly this filename. A reviewer opening the Info tab would be told to edit a file that no longer exists. - demos/baba-is-ai/README.md: setup step and file table - demos/baba-is-ai/baba-is-ai.nlogox: Info tab Verified: model still compiles headless against NetLogo 7.0.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66. Unblocks #61.
Why
color-sharingfailed on setup. It passed"demos/config"tollm:load-config, which resolves against the model's own directory first, so the lookup becamedemos/color-sharing/demos/configand never matched. Its ownconfig.txtsat beside it, unused.Three naming conventions were in use across five demos —
config,config.txt, and a path-prefixed form.What
demos/baba-is-ai/configanddemos/provider-sensitivity/configtoconfig.txt; update both modelscolor-sharingatconfig.txtdemos/color-sharing/config.txt— it existed locally but was never committed, so a fresh clone got a broken demo even with the path fixed.gitignorenegations so theconfig-*.txtsecret-protection pattern from chore: gitignore __pycache__ and config files with API keys #42 does not swallow themWhy this unblocks #61
The baba-is-ai library re-submission was rejected over the extensionless config filename. That is now
config.txt.Secrets
Every config was checked before tracking. All carry placeholder keys (
YOUR_...) or local Ollama endpoints. No secrets added.Verification
All three modified models compile headless against NetLogo 7.0.3. The config-resolution check that flagged
color-sharingnow passes clean.