Repository navigation
Prepare the reports for Quarto 1.11.9 - #206
Merged
Merged
Conversation
…lies on The reports move from Quarto 1.10.18 to 1.11.9. Build-ValidationReport.ps1 refuses a public address that carries a line terminator because Quarto drops such a -P argument without a warning, and the comment saying so cites parseMetadataFlagValue() in src/command/render/flags.ts. That file is the same at both versions, so the citation names the version the reports now render with. Quarto 1.11 also changes how a document's front matter meets the metadata its project, profiles, directories, and metadata files set. Before Pandoc runs, 1.10.18 let the front matter replace the merged value of a key that is not one of Quarto's own options, whose lists it combined already; 1.11.9 merges the two where execution leaves the key unchanged, so lists are combined, a single value joins a list beside it, and maps merge key by key, while a single value still replaces a single value. A report's front matter sets its lang and params, which no other source sets, and the Partner Certificate's also sets date-meta, a single value on both sides, so no report renders differently for it. The Validation Report's _quarto.yml gains the final newline it lacked.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the documentation and configuration-formatting changes.
No open issues 🎉
What changed in this PR
This PR prepares report documentation and configuration formatting for the reporting image’s move to Quarto 1.11.9. It does not change report behaviour or upgrade Quarto itself.
Changes:
- Updates the Quarto version cited in the validation wrapper’s explanation of rejected line terminators.
- Removes trailing whitespace and adds the missing final newline in the Validation Report configuration.
| File | Description |
|---|---|
scripts/Build-ValidationReport.ps1 |
Updates a comment’s Quarto version reference to 1.11.9; validation logic is unchanged. |
reports/Validation-Report/_quarto.yml |
Normalizes whitespace and the final newline without changing configuration values. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reports move from Quarto 1.10.18 to 1.11.9 with the reporting image. Two things in this repository depend on the version:
scripts/Build-ValidationReport.ps1refuses a public address that carries a line terminator, because Quarto drops such a-Pargument without a warning. The comment saying so citesparseMetadataFlagValue()in Quarto'ssrc/command/render/flags.ts, which is the same at both versions, so it now names the version the reports render with.langandparams, which no other source sets, and the Partner Certificate's also setsdate-meta, a single value on both sides, so no report renders differently.The Validation Report's
_quarto.ymlgains the final newline it lacked.Quarto 1.11.9 also gives every external link in the reports' HTML a description for screen readers, "(opens in a new tab)", which it has in English only, and Bootstrap HTML a "Skip to main content" link that it does not translate into Greek. Supplying both in every report language belongs with the translation of the text Quarto generates in the reports.