Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
API state is not consistently preserved, disabling behavior is unreliable, and Lite release packaging is incomplete.
6 open findings
What changed in this PR
Adds a public region-management API and a Lite build variant.
Changes:
- Adds APIs for dynamic regions, DTLS control, and official-region disabling.
- Introduces Default and Lite build configurations.
- Updates region regeneration and CI artifact handling.
| File | Description |
|---|---|
src/ReloadButton.cs |
Integrates API filtering into manual refresh. |
src/RegionInstaller.csproj |
Defines Default/Lite outputs and DLL renaming. |
src/RegionInstaller.cs |
Adds variant naming and logging. |
src/RegionFileGenerator.cs |
Adds strict official-region filtering. |
src/Api/RegionApi.cs |
Implements the region-management API. |
.github/workflows/build.yml |
Builds and uploads both variants. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| uses: softprops/action-gh-release@v2 | ||
| with: | ||
| files: src/bin/Debug/net6.0/RegionInstaller.dll | ||
| files: src/bin/Default/net6.0/RegionInstaller.dll |
Comment on lines
+67
to
+68
| forceDisableInnersloth = true; | ||
| TriggerRefresh(); |
Comment on lines
+115
to
+116
| string regionJsonPath = Path.Combine(Application.persistentDataPath, "regionInfo.json"); | ||
| RegionFileGenerator.RegenerateRegionFile(regionJsonPath, configData, forceDisableInnersloth); |
| { | ||
| if (!reg.IsValid) continue; | ||
|
|
||
| if (ignoreInnerslothAndGlitch && InnerslothRegions.IsOfficialInnersloth(reg.Name)) |
| public const string Version = "1.2.1"; | ||
| #endif | ||
|
|
||
| public const string Version = "1.0.0"; |
|
|
||
| string regionJsonPath = Path.Combine(Application.persistentDataPath, "regionInfo.json"); | ||
| RegionFileGenerator.RegenerateRegionFile(regionJsonPath, configData); | ||
| RegionFileGenerator.RegenerateRegionFile(regionJsonPath, configData, shouldDisableInnersloth); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an API to RegionInstaller.
Changes: