Skip to content

Add LOD texture sampling and validate access policy values - #101

Merged
SirLynix merged 2 commits into
NazaraEngine:mainfrom
ArthurVasseur:av/texture-sampling-fixes
Aug 15, 2026
Merged

Add LOD texture sampling and validate access policy values#101
SirLynix merged 2 commits into
NazaraEngine:mainfrom
ArthurVasseur:av/texture-sampling-fixes

Conversation

@ArthurVasseur

Copy link
Copy Markdown
Contributor
  • Add TextureSampleExplicitLod, exposed as Sampler.SampleLevel(uv, lod)
  • Validate access policy values for texture2D[...] and storage[...]

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 76.43%. Comparing base (6be2f9d) to head (1ee9bd4).

Files with missing lines Patch % Lines
src/NZSL/SpirV/SpirvAstVisitor.cpp 95.23% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   81.37%   76.43%   -4.95%     
==========================================
  Files         150      207      +57     
  Lines       18694    25769    +7075     
  Branches        0     7613    +7613     
==========================================
+ Hits        15213    19697    +4484     
- Misses       3481     5953    +2472     
- Partials        0      119     +119     
Files with missing lines Coverage Δ
include/NZSL/SpirV/SpirvAstVisitor.hpp 100.00% <ø> (ø)
...Transformations/ConstantPropagationTransformer.cpp 69.86% <ø> (-0.93%) ⬇️
...rc/NZSL/Ast/Transformations/ResolveTransformer.cpp 83.48% <100.00%> (+0.75%) ⬆️
src/NZSL/GlslWriter.cpp 85.18% <100.00%> (-0.36%) ⬇️
src/NZSL/LangWriter.cpp 87.76% <100.00%> (-0.40%) ⬇️
tests/src/Tests/ComputeTests.cpp 100.00% <100.00%> (ø)
tests/src/Tests/ErrorsTests.cpp 100.00% <ø> (ø)
src/NZSL/SpirV/SpirvAstVisitor.cpp 84.03% <95.23%> (-3.87%) ⬇️

... and 148 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be2f9d...1ee9bd4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SirLynix
SirLynix merged commit 358deaf into NazaraEngine:main Aug 15, 2026
64 of 68 checks passed
@SirLynix

Copy link
Copy Markdown
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants