Skip to content

fix: return object from generated retain override #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rbudnar wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: return object from generated retain override #480

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions NativeScript/runtime/ClassBuilder.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,9 @@ void ScopeClassNameToIsolate(std::string& name, int isolateId) {
/// instances map), we unprotect the corresponding JavaScript object in order to make both
/// of them destroyable/GC-able. When the JavaScript object is GC-ed we release the native
/// counterpart as well.
void (*retain)(id, SEL) =
(void (*)(id, SEL))FindNotOverridenMethod(extendedClass, @selector(retain));
IMP newRetain = imp_implementationWithBlock(^(id self) {
id (*retain)(id, SEL) =
(id (*)(id, SEL))FindNotOverridenMethod(extendedClass, @selector(retain));
IMP newRetain = imp_implementationWithBlock(^id(id self) {
if (!isolateWrapper.IsValid()) {
return retain(self, @selector(retain));
}
Expand Down
Loading