chore: rebuild Android and Apple native libraries, 3.0.0-beta.0 - #178
Merged
Merged
Conversation
The Android GL context asks for a low priority with ContextAttributesBuilder::with_priority, which glutin 0.32.0 does not have. A lockfile still on 0.32.0 fails to build canvas-core.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuilt native libraries for #174–#177 and bumped the packages to
3.0.0-beta.0. Built locally fromf5424ba737with the same steps asbuild-native.yml.packages/canvas/platforms/android/canvas-release.aar(4 ABIs)make android,gradlew :canvas:assembleReleasepackages/canvas/platforms/ios/CanvasNative.xcframework(iOS, simulator, visionOS, tvOS)make ios visionos tvos,canvas-build.shpackages/canvas-svg/platforms/android/canvassvg-release.aar(4 ABIs)make android-svg,copy-svg-android.sh,gradlew :canvassvg:assembleReleasecanvas-2d/canvas-corechangespackages/canvas-svg/platforms/ios/CanvasSVG.xcframeworkmake svg,canvas-svg-build.shcanvas-2d/canvas-corechangesThe builds also update the committed
dist/copies and the canvas-svgjniLibs, as CI does.canvas_native.hcatches up with declarations already in the source from #177.audio-context is unchanged since its last build and is not rebuilt. Windows modules come from #177.
canvas-core: glutin 0.32.3#174 calls
ContextAttributesBuilder::with_priority, which glutin 0.32.0 does not have.canvas-corestill accepted 0.32.0, so a lockfile on that version failed to build for Android. The requirement is now 0.32.3.Checks
Java_org_nativescript_canvas_Utils_nativeRunWithWebGLandcanvas_native_canvases_behindinlibcanvasnative.so(4 ABIs);canvas_native_ios_webgl_runandcanvas_native_canvases_behindin all 6CanvasNativeslices.