fix(polyfill): report already-connected gamepads to the first listener - #163
Merged
Merged
Conversation
hookGamepadListeners started the gamepad backend before registering the caller's listener. The backends report already-connected controllers synchronously on start, so the first gamepadconnected listener missed them. Register the listener first.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hookGamepadListenersstarted the gamepad backend before registering the caller's listener. The iOS, Android and Windows backends report controllers that are already connected synchronously when they start, so the firstgamepadconnectedlistener never saw them. The listener is now registered first.packages/canvas-polyfill/gamepad.ts: register the listener, then start the backend.packages/canvas-polyfill/__test__/gamepad.test.mjs: regression test using a fake backend that reports a pad on start. It fails before the fix and passes after.@nativescript/canvas-polyfillto3.0.0-alpha.19.Testing
node --test packages/canvas-polyfill/__test__/gamepad.test.mjs packages/canvas-gamepad/__test__/common.test.mjspasses (8 tests).