Skip to content

fix(android): apply keyboardOptions to BareTextInputRenderer - #51

Merged
simonhamp merged 2 commits into
NativePHP:mainfrom
wilsonatb:fix/android-bare-text-keyboard-options
Sep 19, 2026
Merged

simonhamp merged 2 commits into
NativePHP:mainfrom
wilsonatb:fix/android-bare-text-keyboard-options

Conversation

@wilsonatb

Copy link
Copy Markdown
Contributor

This PR fixes an issue on Android where the BareTextInputRenderer failed to display the correct IME keyboard types (e.g., decimal, number).

The BasicTextField was being built without keyboardOptions, meaning the keyboard prop was parsed but never actually sent to the IME, resulting in the default text keyboard always being shown.

Changes

  • Added import androidx.compose.foundation.text.KeyboardOptions to BareTextInputRenderer.kt.
  • Injected keyboardOptions = keyboardOptionsFor(props) into the BasicTextField constructor.

Notes

  • The outlined and filled renderers already implement this correctly.
  • iOS is completely unaffected, as it delegates to NativeUITextInputCore which correctly applies .keyboardType natively.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 35c47662-bb50-4e56-bedf-8eacfc23440d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@simonhamp
simonhamp merged commit a7718b8 into NativePHP:main Sep 19, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants