Reverts wxConfig to NREL for backward compatibility#199
Merged
brtietz merged 1 commit intoJun 30, 2026
Conversation
This avoids issue with information written to Windows registry and Mac/Linux config files not being correctly loaded for 2026 versions of SAM/DView and later. An alternative approach would be to add a condition when "NREL" entries in the Windows registry or Mac/Linux configuration files exist to read them and copy them to new "NLR" entries. The alternative approach would require more time and testing to implement than this simple approach of preserving the "NREL" entries.
sjanzou
approved these changes
Jun 30, 2026
sjanzou
left a comment
sjanzou
left a comment
Collaborator
There was a problem hiding this comment.
Registry check after build on Windows 11 working - thanks for reverting all of these.
Long term we should switch to "NLR" with the porting over of the "NREL" as you suggested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids issue with information written to Windows registry and Mac/Linux config files not being correctly loaded for 2026 versions of SAM/DView and later.
An alternative approach would be to add a condition when "NREL" entries in the Windows registry or Mac/Linux configuration files exist to read them and copy them to new "NLR" entries. The alternative approach would require more time and testing to implement than this simple approach of preserving the "NREL" entries.
This goes with:
Revert wxConfig to NREL for backward compatibility SAM#2225
https://github.com/NatLabRockies/SAM-private/pull/161
I forgot to include this WEX repository when I made those PRs.