OM Refactor: Promote Cell Design Parameters - #99
Draft
elenya-grant wants to merge 42 commits into
Draft
Conversation
…olyzer into om_refactor/structure
…rolyzer into om_refactor/structure
…e input parameters
…rameters changes results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OM Refactor: Promote Cell Design Parameters
This is a follow-on to PR #91 and aims to resolve Issue #94. The changes introduced in this PR will be easier to see once PR #91 is merged in.
3 different instances of the cell component are used in a cluster group. To ensure that all cell components change if someone is optimizing the cell parameters, the design parameters of each cell should be promoted up to the system level (eventually, we would want the ability to promote these up to the "cluster" level in case each cluster has a unique cell design).
Related issue, if one exists
Intended to resolve Issue #94
Impacted areas of the software
electrolyzer/components/cell/cell_design_params.py: new file with functionget_cell_params_for_modelelectrolyzer/core/bert.pyload_config(): added new boolean attributeidentical_cellsas a placeholder. This attribute is True if all clusters have identical cells and can be used to determine which level to promote the cell parameters to in the future (if clusters have unique cell designs)create_controller_cluster_connector(): added cell_design_params as an inputcreate_cluster_simulation_block(): added cell_design_params as an inputcreate_components(): updated to callget_cell_params_for_model()Additional supporting information
Test results, if applicable