Default and upgrade updates from release candidate#2229
Open
mjprilliman wants to merge 2 commits into
Open
Conversation
| "spec_mode": 0.0, | ||
| "start_day_of_year": 3.335046e-317, | ||
| "start_day_of_year": 0.0, | ||
| "start_day_of_year_load_ui": 3.335046e-317, |
Collaborator
There was a problem hiding this comment.
Looks like there may be one more that needs to be updated- I see it here but imagine it may be in multiple configs?
| "standby_control": 0.0, | ||
| "start_day_of_year": 3.335046e-317, | ||
| "start_day_of_year": 0.0, | ||
| "start_day_of_year_load_ui": 3.335046e-317, |
Collaborator
There was a problem hiding this comment.
looks like it may be for all btm configs
janinefreeman
left a comment
janinefreeman
left a comment
Collaborator
There was a problem hiding this comment.
Looks good other than the one variable I flagged! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
-Update upgrade messages
-0 integer for start day of year calculated variable
-Extra ITC variable removal
[ include directions for reviewers if necessary- what or how should they test or review ]
Fixes # (issue(s))
Corresponding branches and PRs:
[ which branches of wex, lk, and ssc should be built with this PR ]
[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]
Unit Test Impact:
[ new tests written? ]
[ expected changes in unit tests or speed of tests? ]
[ expected changes in test_results files? ]
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)