Repository navigation
Feat/graphql versioning and cli migration notes - #1155
Merged
Nanle-code merged 4 commits intoOct 2, 2026
Merged
Nanle-code merged 4 commits into
Nanle-code merged 4 commits into
Conversation
added 4 commits
October 1, 2026 12:58
Nanle-code#781) - Add GRAPHQL_SCHEMA_VERSIONING.md: 90-day deprecation SLA, versioning policy, deprecation process, worked example, and approvals required - Link new policy from GRAPHQL_GUIDE.md (acceptance criteria requirement) - Add src/graphql/schema_deprecations.rs: typed DeprecatedField registry with unit tests enforcing 90-day window and non-empty reasons - Add SCHEMA_VERSION constant to src/graphql/schema.rs - Add scripts/check-graphql-deprecations.sh: CI lint that fails when a deprecated field is removed before its earliest_removal date elapses - Add .github/workflows/graphql-schema-lint.yml: required CI job running the deprecation-window check on every src/graphql/** change - Add GraphQL breaking-change checklist to .github/pull_request_template.md Closes Nanle-code#781
…anle-code#780) - Add src/utils/cli_migration_notes.rs: core diff engine and markdown renderer; HUMAN_REVIEW_BANNER constant is unconditional and prepended by render_migration_notes() in every code path - Add src/commands/migrate_notes.rs: 'starforge migrate-notes' subcommand with generate / snapshot / diff / docs sub-subcommands; docs subcommand embeds the maintainer workflow doc via include_str! - Wire MigrateNotes into src/main.rs Commands enum and dispatch match - Register cli_migration_notes in src/utils/mod.rs - Register migrate_notes in src/commands/mod.rs - Add docs/MIGRATION_NOTES_WORKFLOW.md: step-by-step maintainer workflow covering when to run, how to review, where to publish, snapshot format - Add tests/fixtures/migrate_notes/{before,after}.json: canonical fixture pair with command rename (network-info→network show), flag rename (--wallet-name→--name), flag became-required (deploy --network), flag rename (--dry-run→--simulate), config key rename, type change - Add tests/cli_migration_notes.rs: integration tests asserting all detected changes, banner always present, version headers, section content Closes Nanle-code#780
…dency Pre-existing issues inherited from upstream/master that blocked cargo fmt: - Remove duplicate tokio-postgres entry in Cargo.toml (was at lines 105 and 146) - Fix invalid let...else syntax in src/utils/soroban.rs (missing match arm comma) - Reformat upstream files to satisfy cargo fmt --all --check None of these changes affect feature logic; all are formatting and manifest corrections required for CI to pass.
…vert test patch in schema_deprecations - Cargo.lock regenerated after the duplicate tokio-postgres entry was removed from Cargo.toml; dependency graph now resolves correctly - src/graphql/schema_deprecations.rs: revert temporary lint-verification test entry (the empty DEPRECATED_FIELDS registry is the correct state)
praizeD10
force-pushed
the
feat/graphql-versioning-and-cli-migration-notes
branch
from
October 1, 2026 14:09
c52c970 to
cd2ca4f
Compare
|
@praizeD10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+20
to
+40
| name: GraphQL Schema Lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Make lint script executable | ||
| run: chmod +x scripts/check-graphql-deprecations.sh | ||
|
|
||
| - name: Check GraphQL deprecation windows | ||
| run: bash scripts/check-graphql-deprecations.sh | ||
|
|
||
| - name: Verify schema_deprecations.rs compiles | ||
| # Compile only the graphql module to catch any Rust errors in the | ||
| # deprecation registry before they reach the main CI build job. | ||
| uses: dtolnay/rust-toolchain@stable | ||
|
|
||
| - name: Install system dependencies | ||
| run: sudo apt-get update && sudo apt-get install -y libudev-dev | ||
|
|
||
| - name: Compile graphql module (deprecation registry check) | ||
| run: cargo check --locked 2>&1 | grep -E "^error" && exit 1 || true |
Author
|
@Manuelshub @Nanle-code please merge and assign points |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of what this PR does and why.
Closes #780
Closes #781
Type of Change
Changes Made
Testing
How has this been tested?
Describe the tests you ran and how to reproduce them.
Test Coverage
Describe what scenarios have been tested:
Code Quality Checklist
cargo fmt)cargo clippy -- -D warnings)Breaking Changes
If checked, describe the breaking changes and migration path:
Documentation
Screenshots (if applicable)
Add screenshots or GIFs for UI changes.
Additional Context
Add any other context about the PR here.
Note: Make sure all tests pass locally before submitting:
cargo test cargo fmt --all cargo clippy -- -D warnings