Repository navigation
test(e2e): browser tests in CI, and approve ADR-0009 to 0011 - #14
Merged
Merged
Conversation
25 Playwright tests in a self-contained e2e/ folder cover the landing and reduced motion, the buyer and organizer views, the language selector (default, switch, persistence, no missing keys on any route), the buyer link and its QR code (decoded by jsQR from a capture of the screen), the offline shell and the 360 px layout. They run in their own CI job so a browser flake never hides the .NET result, with a pinned lockfile, npm audit and Dependabot for e2e/. Nothing in e2e/ ships and the panel gains no dependency.
ADR-0011 (Proposed) records the choice of Playwright outside the panel. REQ-090 to REQ-096 and REQ-101 to REQ-105 move into the requirements with their tests; the traceability gap now lists only what is still not automated (installing on a physical phone). Runbook, README, changelog and the spec task lists are updated.
test(e2e): verify the panel in a real browser
The owner delegated the decision to the agent's best judgement on 2026-10-21. SQLite in WAL mode, the service worker that caches the shell and never the API, and Playwright browser tests outside the panel are approved as written. AGENTS.md records Playwright as a development-only tool living in e2e/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR #13 was merged into
feat/mobile-pwajust after #12 had gone intomain, so the browser tests never reachedmain. This PR brings them, plus the ADR approvals.e2e/: 25 Playwright tests against the real application (landing and reduced motion, buyer and organizer views, language, buyer link and QR decoded byjsQR, offline shell, 360 px layout), with their own CI job,npm auditand Dependabot. Details in test(e2e): verify the panel in a real browser #13.Approved: the owner delegated the decision to the agent's best judgement on 2026-10-21, and the ADRs record that.AGENTS.mdlists Playwright as a development-only tool living ine2e/.Verification
npx playwright test25/25 locally;dotnet test123/123;actionlintandgitleaksclean. TheBrowser testsjob has not yet run on a GitHub runner: this PR is its first run (Linux, Playwright's bundled Chromium).