Use underscore-separated Pulse AppStorage keys - #4
Merged
NachoSoto merged 2 commits intoJul 17, 2026
Merged
Conversation
tjni
marked this pull request as ready for review
July 17, 2026 07:00
tjni
force-pushed
the
agent/pulse-appstorage-underscore-keys
branch
from
July 17, 2026 07:03
9a0d13b to
bb1cddc
Compare
erichoracek
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Replace six dotted Pulse UI
@AppStoragekeys with underscore-separated keys. Add a regression test for the captured hang and a reminder to keep future keys dot-free.Why
I captured a deadlock: while SwiftUI rendered, an unrelated background
UserDefaultswrite notified Pulse's console-mode@AppStorageobserver.Research showed that dotted keys can make
@AppStorageobserve the entire defaults store. Dot-free keys let SwiftUI observe each setting separately and avoid the deadlock.Existing Pulse UI preferences will reset once after this change. I left out migration for the moment pending feedback.
Upstream PR: kean#376