Skip to content

Bump tensordict to 0.12.4 minimum#1675

Merged
peterdsharpe merged 4 commits into
NVIDIA:mainfrom
peterdsharpe:psharpe/tensordict-upgrade
May 29, 2026
Merged

Bump tensordict to 0.12.4 minimum#1675
peterdsharpe merged 4 commits into
NVIDIA:mainfrom
peterdsharpe:psharpe/tensordict-upgrade

Conversation

@peterdsharpe
Copy link
Copy Markdown
Collaborator

PhysicsNeMo Pull Request

Description

TensorDict 0.12.4 includes some new critical torch.compile and thread-safety improvements for these issues, which are relevant to GLOBE, PNM-Mesh, and our unified external aero recipe:

Fixes for these were added here: pytorch/tensordict#1709 and pytorch/tensordict#1711.

And these are now released as part of TensorDict 0.12.4.

Checklist

Dependencies

Review Process

All PRs are reviewed by the PhysicsNeMo team before merging.

Depending on which files are changed, GitHub may automatically assign a maintainer for review.

We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.

AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 27, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@peterdsharpe
Copy link
Copy Markdown
Collaborator Author

/blossom-ci

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 27, 2026

Greptile Summary

This PR removes the <0.12 upper bound on tensordict and sets a new minimum of >=0.12.4, which includes upstream fixes for torch.compile regressions and thread-safety issues relevant to GLOBE, PNM-Mesh, and the unified external aero recipe.

  • pyproject.toml: tensordict constraint changed from >=0.11.0,<0.12 to >=0.12.4; the now-resolved TODO comments are also cleaned up.
  • uv.lock: Lock file regenerated; beyond tensordict itself, uv also advanced several unrelated packages to their latest compatible versions (e.g. aiobotocore, botocore, click, certifi, numpy 2.4.4→2.4.6), which is expected behaviour when re-solving the full dependency graph.

Important Files Changed

Filename Overview
pyproject.toml Bumps tensordict minimum from >=0.11.0,<0.12 to >=0.12.4, removing the torch.compile regression upper bound and its associated comments.
uv.lock Lock file regenerated after the tensordict bump; many unrelated packages (aiobotocore, botocore, click, certifi, cachetools, numpy, etc.) were also updated to their latest compatible versions as a side effect of running uv lock.

Reviews (1): Last reviewed commit: "Bump tensordict to 0.12.4 minimum" | Re-trigger Greptile

Copy link
Copy Markdown
Collaborator

@coreyjadams coreyjadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering half these PRs are coming to tensordict from our dev team, LGTM 😅

@peterdsharpe
Copy link
Copy Markdown
Collaborator Author

/blossom-ci

@peterdsharpe
Copy link
Copy Markdown
Collaborator Author

/ok to test 01bc273

@peterdsharpe
Copy link
Copy Markdown
Collaborator Author

/ok to test 604c5ec

@peterdsharpe
Copy link
Copy Markdown
Collaborator Author

/blossom-ci

@peterdsharpe peterdsharpe enabled auto-merge May 29, 2026 04:12
@peterdsharpe
Copy link
Copy Markdown
Collaborator Author

/blossom-ci

1 similar comment
@peterdsharpe
Copy link
Copy Markdown
Collaborator Author

/blossom-ci

@peterdsharpe peterdsharpe added this pull request to the merge queue May 29, 2026
Merged via the queue into NVIDIA:main with commit 7edf071 May 29, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants