[nri-plugin] support injection of management CDI devices in multiple namespaces#1901
Open
tariq1890 wants to merge 1 commit into
Open
[nri-plugin] support injection of management CDI devices in multiple namespaces#1901tariq1890 wants to merge 1 commit into
tariq1890 wants to merge 1 commit into
Conversation
…namespaces This commit exposes a new CLI flag so that users can specify additional namespaces that are authorised for management CDI device injection via the NRI plugin. Currently, users can only inject management CDI devices to containers/pods that are in the same namespace as that of the toolkit pod. With this change, users can specify can additional namespaces whose pods may need management CDI device access. Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
Coverage Report for CI Build 28068807699Coverage decreased (-0.02%) to 43.526%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit exposes a new CLI flag so that users can specify additional namespaces that are authorised for management CDI device injection via the NRI plugin. Currently, users can only inject management CDI devices to containers/pods that are in the same namespace as that of the toolkit pod. With this change, users can specify can additional namespaces whose pods may need management CDI device access.