drop the usage of the E2E_SSH_USER secret#1889
Merged
Merged
Conversation
Coverage Report for CI Build 27589237511Coverage remained the same at 43.541%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
cdesiniotis
approved these changes
Jun 15, 2026
"ubuntu" being the SSH user of AWS Ubuntu EC2 instances is a well-known fact. There is not much to gain from persisting this value as a secret. Source: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/managing-users.html Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
rm-e2e-ssh-user-secret
branch
from
a51fa7a to
4d77ce7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"ubuntu" being the SSH user of AWS Ubuntu EC2 instances is a well-known fact. There is not much to gain from persisting this value as a secret.
Source: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/managing-users.html