Skip to content

fix(nvct): request task instances from SIS #1042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbaum1994 merged 2 commits into from
Aug 21, 2026
Merged

fix(nvct): request task instances from SIS #1042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4abeb23
fix(nvct): request task instances from SIS
sbaum1994 Aug 20, 2026
469e40a
test(icms-translate): cover legacy SPOT actions
sbaum1994 Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ces/cloud-tasks/nvct-core/src/main/java/com/nvidia/nvct/service/icms/IcmsStubService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class CreateInstancesResponse {
UUID requestId;
}

@PostExchange(value = "/v1/si?Action=RequestInstances",
@PostExchange(value = "/v1/si?Action=RequestInstancesForTask",
accept = "application/json",
contentType = "application/x-www-form-urlencoded")
CreateInstancesResponse createInstance(
Expand Down
12 changes: 7 additions & 5 deletions ...ces/cloud-tasks/nvct-core/src/test/java/com/nvidia/nvct/service/icms/IcmsServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,8 +164,7 @@ void shouldScheduleInstanceForContainerBasedTask() {
// Assert
assertThat(requestId).isNotNull();
List<ServeEvent> allServeEvents = MockIcmsServer.getMockIcmsServer().getAllServeEvents();
String formUrlEncodedBody = allServeEvents.getFirst().getRequest().getBodyAsString();
validateTaskInstancePayload(formUrlEncodedBody, task1);
validateTaskInstanceRequest(allServeEvents.getFirst(), task1);

taskService.deleteTask(task1);
}
Expand All @@ -183,8 +182,7 @@ void shouldScheduleInstanceForHelmBasedTask() {
// Assert
assertThat(requestId).isNotNull();
List<ServeEvent> allServeEvents = MockIcmsServer.getMockIcmsServer().getAllServeEvents();
String formUrlEncodedBody = allServeEvents.getFirst().getRequest().getBodyAsString();
validateTaskInstancePayload(formUrlEncodedBody, task1);
validateTaskInstanceRequest(allServeEvents.getFirst(), task1);

taskService.deleteTask(task1);
}
Expand All @@ -209,7 +207,11 @@ void shouldTolerateTerminateWhenIcmsWorkloadNotFound() {
}

@SneakyThrows
private void validateTaskInstancePayload(String formUrlEncodedBody, TaskEntity task) {
private void validateTaskInstanceRequest(ServeEvent serveEvent, TaskEntity task) {
assertThat(serveEvent.getRequest().queryParameter("Action").firstValue())
.isEqualTo("RequestInstancesForTask");

String formUrlEncodedBody = serveEvent.getRequest().getBodyAsString();
Map<String, Object> paramMap = Arrays.stream(formUrlEncodedBody.split("&"))
.map(s -> s.split("=", 2))
.collect(Collectors.toMap(
Expand Down
2 changes: 1 addition & 1 deletion ...ane-services/cloud-tasks/nvct-core/src/test/java/com/nvidia/nvct/util/MockIcmsServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ public static void start(
mockIcmsServer = new WireMockServer(config);
mockIcmsServer.stubFor(post(urlPathEqualTo("/v1/si"))
.withQueryParam("Action",
new EqualToPattern("RequestInstances"))
new EqualToPattern("RequestInstancesForTask"))
.willReturn(aResponse().withStatus(200)
.withTransformers(instanceRequestExtension.getName())
.withHeader(CONTENT_TYPE, APPLICATION_JSON_VALUE)
Expand Down
20 changes: 20 additions & 0 deletions src/libraries/go/lib/pkg/icms-translate/translate/common/types_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,16 @@ func TestMessageAction_Normalize(t *testing.T) {
input: MessageAction("RequestSparInstancesForTask"),
expected: TaskCreationAction,
},
{
name: "legacy SPOT function action normalizes",
input: MessageAction("RequestSpotInstances"),
expected: FunctionCreationAction,
},
{
name: "legacy SPOT task action normalizes",
input: MessageAction("RequestSpotInstancesForTask"),
expected: TaskCreationAction,
},
{
name: "legacy RequestInstances action normalizes",
input: MessageAction("RequestInstances"),
Expand Down Expand Up @@ -236,6 +246,16 @@ func TestMessageAction_UnmarshalJSON(t *testing.T) {
json: `"RequestSparInstancesForTask"`,
expected: RequestICMSInstancesForTask,
},
{
name: "legacy RequestSpotInstances normalizes to RequestICMSInstances",
json: `"RequestSpotInstances"`,
expected: RequestICMSInstances,
},
{
name: "legacy RequestSpotInstancesForTask normalizes to RequestICMSInstancesForTask",
json: `"RequestSpotInstancesForTask"`,
expected: RequestICMSInstancesForTask,
},
{
name: "legacy RequestInstances normalizes to RequestICMSInstances",
json: `"RequestInstances"`,
Expand Down
Loading