-
Notifications
You must be signed in to change notification settings - Fork 51
fix(grpc-proxy): purge unclaimed stateful work on shutdown #1031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
balajinvda
wants to merge
6
commits into
main
Choose a base branch
from
fix/grpc-proxy-purge-pending-work-on-shutdown
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3b5a38d
fix(grpc-proxy): purge unclaimed stateful work on shutdown
balaji-g 069be46
fix(grpc-proxy): close the shutdown window that orphaned queued work
balaji-g 152d181
test(grpc-proxy): make the invocation drain assertion unambiguous
balaji-g 2c0f94f
test(grpc-proxy): remove a timing flake in the drain assertion
balaji-g 1a869d1
refactor(grpc-proxy): drop the tunables added by the shutdown purge
balaji-g 1bece4e
chore(grpc-proxy): move quic-go to v0.61.0
balaji-g File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
src/invocation-plane-services/grpc-proxy/proxy/invocation/pending_work.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /* | ||
| SPDX-FileCopyrightText: Copyright (c) NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
| package invocation | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
|
|
||
| "github.com/google/uuid" | ||
| "github.com/nats-io/nats.go/jetstream" | ||
| ) | ||
|
|
||
| // The work queue a stateful invocation lands in. These are owned by the | ||
| // invocation service, which publishes to requestWorkSubject and removes a | ||
| // cancelled request with the same subject-filtered purge used here. The | ||
| // formats are duplicated rather than shared because the owning service is | ||
| // written in another language; they must not drift. | ||
| func requestWorkStream(region, functionVersionId string) string { | ||
| return fmt.Sprintf("rq_%s_%s", region, functionVersionId) | ||
| } | ||
|
|
||
| func requestWorkSubject(region, functionVersionId string, requestId uuid.UUID) string { | ||
| return fmt.Sprintf("rq.%s.%s.%s", region, functionVersionId, requestId) | ||
| } | ||
|
|
||
| // PurgePendingWork drops a stateful work request that is still queued. | ||
| // | ||
| // It is called for sessions this pod issued a worker token for that never came | ||
| // back to CONNECT, at the point the pod is shutting down. Those tokens only | ||
| // exist in this pod's memory, so every one of those queued requests is already | ||
| // guaranteed to fail authentication whenever a worker eventually pulls it. Left | ||
| // in place they are pulled anyway, occupy a worker concurrency slot, and fail, | ||
| // which is what keeps a saturated function at zero goodput long after the | ||
| // restart that caused it. | ||
| // | ||
| // Purging by subject only removes messages still held by the stream. A session | ||
| // that already has a worker attached had its message delivered, so an | ||
| // established session is unaffected and remains free to reattach to another | ||
| // pod. | ||
| func (f *FunctionInvoker) PurgePendingWork(ctx context.Context, requestId uuid.UUID, functionVersionId string) error { | ||
| streamName := requestWorkStream(f.region, functionVersionId) | ||
| stream, err := f.js.Stream(ctx, streamName) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to look up work stream %s: %w", streamName, err) | ||
| } | ||
| subject := requestWorkSubject(f.region, functionVersionId, requestId) | ||
| if err := stream.Purge(ctx, jetstream.WithPurgeSubject(subject)); err != nil { | ||
| return fmt.Errorf("failed to purge work subject %s: %w", subject, err) | ||
| } | ||
| return nil | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
Restore invocation admission draining before the purge snapshot.
Lines 360-365 retain the
onWorkerAuthSettostartNewSessionrace.InvokeStatefulFunctionrecords pending work before it publishes the work request. IfClosesnapshots and purges in that interval, the later publish leaves queued work that this pod can no longer authenticate or purge.Close admission, drain admitted invocations with a bounded timeout, then snapshot
pendingWork. Add a deterministic test for this interleaving.🤖 Prompt for AI Agents