feat(vanity-gateway): pass the LLM Gateway endpoint through the stack - #1026
Draft
Max-NV wants to merge 1 commit into
Draft
feat(vanity-gateway): pass the LLM Gateway endpoint through the stack#1026Max-NV wants to merge 1 commit into
Max-NV wants to merge 1 commit into
Conversation
The self-managed stack enumerates the Vanity Gateway config keys one by one when rendering chart values, so llmGatewayEndpoint was dropped and the gateway failed to start with "LLM_GATEWAY_ENDPOINT is required" whenever a host was declared under mappingConfig.v2config.llmGateway. The mappingConfig half already passed through untouched, so the section could be configured but never worked. Adds the key to the rendered config block and documents it in base.yaml with the in-cluster LLM Gateway as the default. Chart and image pins are not bumped here. Both need a published artifact carrying the service-side change, which does not exist yet. Signed-off-by: Max Xing <mxing@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Max-NV
marked this pull request as draft
August 20, 2026 00:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
The self-managed stack enumerates the Vanity Gateway config keys individually when rendering chart values, so
llmGatewayEndpointwas dropped. Any deployment declaring a host undermappingConfig.v2config.llmGatewayfailed to start with "LLM_GATEWAY_ENDPOINT is required".Additional Details
The
mappingConfighalf already passed through untouched viadig "addons" "vanityGateway" "mappingConfig" ..., so an operator could configure the section but it could never work. This adds the missing key to the renderedconfig:block and documents it inbase.yaml, defaulting to the in-cluster LLM Gateway service.Chart and image pins are deliberately not bumped. Both need a published artifact carrying the service-side change, which does not exist yet. That bump is follow-up work once the service PR lands and releases.
Stacked on #1025, which adds the chart key. Merging this first would break installs: the chart config block is
additionalProperties: false, so it would reject the value the stack now sends. Base is set to that branch and will retarget tomainwhen it merges.For the Reviewer
Two lines of substance. The
global.yaml.gotmplline mirrors the adjacentnvcfApiEndpointline exactly.For QA
Rendered the full chain rather than eyeballing the template. Using a scratch environment enabling
addons.vanityGatewayandaddons.llmwith onellmGatewayhost,helmfile write-valuesproducedllmGatewayEndpoint: http://llm-api-gateway.nvcf.svc.cluster.local:8080alongside the mapping section, and feeding those exact values into the chart withhelm templateemitted bothLLM_GATEWAY_ENDPOINTin the env ConfigMap and the host in the mapping ConfigMap. Scratch files were removed. No QA needed.Issues
Relates to #1021
Checklist