feat(vanity-gateway): serve LLM Gateway routes on configured hosts #1022
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| /* | ||
| SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package gateway | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "net" | ||
| "net/http" | ||
| "net/http/httputil" | ||
| "net/url" | ||
| "time" | ||
|
|
||
| config "ai-api-gateway-service/gateway_config" | ||
|
|
||
| "go.opentelemetry.io/otel/trace" | ||
| ) | ||
|
|
||
| // LLMGatewayDirector proxies vanity routes to the LLM Gateway without altering | ||
| // the request body. The LLM Gateway resolves the target function from the model | ||
| // field the client already supplies, so the gateway forwards the request as-is | ||
| // rather than stamping function-id headers or rewriting the path. | ||
| type LLMGatewayDirector struct { | ||
| rp *httputil.ReverseProxy | ||
| host string | ||
| scheme string | ||
| } | ||
|
|
||
| type LLMGatewayRequest struct { | ||
| CustomHeaders config.CustomHeaders | ||
| EOL time.Time | ||
| OfflineMessage string | ||
| } | ||
|
|
||
| func NewLLMGatewayDirector(endpoint string, transport http.RoundTripper) (*LLMGatewayDirector, error) { | ||
| endpointUrl, err := url.Parse(endpoint) | ||
| if err != nil || endpointUrl.Scheme == "" || endpointUrl.Host == "" { | ||
| return nil, fmt.Errorf("invalid LLM Gateway endpoint: %s", endpoint) | ||
| } | ||
| return &LLMGatewayDirector{ | ||
| rp: newGatewayReverseProxy(transport), | ||
| host: endpointUrl.Host, | ||
| scheme: endpointUrl.Scheme, | ||
| }, nil | ||
|
Comment on lines
+49
to
+58
There was a problem hiding this comment. 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- relevant files ---'
git ls-files | rg '(^|/)(AGENTS\.md|llm_gateway_director\.go|.*health.*|.*gateway.*test.*)$' | head -200
printf '%s\n' '--- director outline ---'
ast-grep outline src/invocation-plane-services/vanity-gateway/gateway/llm_gateway_director.go
printf '%s\n' '--- director source ---'
cat -n src/invocation-plane-services/vanity-gateway/gateway/llm_gateway_director.go | sed -n '1,180p'
printf '%s\n' '--- related symbols ---'
rg -n -C 4 'NewLLMGatewayDirector|newGatewayReverseProxy|ServeProxy|healthManager|LLM_GATEWAY_ENDPOINT|JoinPath' src/invocation-plane-services/vanity-gatewayRepository: NVIDIA/nvcf Length of output: 44604 🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- repository guidance ---'
cat -n AGENTS.md | sed -n '1,220p'
if [ -f src/invocation-plane-services/vanity-gateway/AGENTS.md ]; then
cat -n src/invocation-plane-services/vanity-gateway/AGENTS.md | sed -n '1,220p'
fi
if [ -f src/invocation-plane-services/vanity-gateway/gateway/AGENTS.md ]; then
cat -n src/invocation-plane-services/vanity-gateway/gateway/AGENTS.md | sed -n '1,220p'
fi
printf '%s\n' '--- health helper ---'
cat -n src/invocation-plane-services/vanity-gateway/gateway/health.go | sed -n '29,90p'
printf '%s\n' '--- director tests ---'
cat -n src/invocation-plane-services/vanity-gateway/gateway/llm_gateway_director_test.go | sed -n '1,230p'
printf '%s\n' '--- reverse proxy helper ---'
cat -n src/invocation-plane-services/vanity-gateway/gateway/vanity_director.go | sed -n '160,215p'Repository: NVIDIA/nvcf Length of output: 25474 🏁 Script executed: #!/bin/bash
set -eu
cat >/tmp/verify_llm_gateway_path.go <<'EOF'
package main
import (
"fmt"
"net/http"
"net/http/httptest"
"net/http/httputil"
"net/url"
)
func main() {
// Model the director: it stores only scheme and host, then mutates the
// incoming request before using the repository's no-op proxy director.
endpoint, _ := url.Parse("http://llm-gateway.example/llm")
incoming, _ := http.NewRequest(http.MethodPost, "http://vanity.example/v1/chat/completions", nil)
incoming.URL.Scheme = endpoint.Scheme
incoming.URL.Host = endpoint.Host
incoming.Host = ""
var got string
upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
got = r.URL.RequestURI()
w.WriteHeader(http.StatusNoContent)
}))
defer upstream.Close()
upstreamURL, _ := url.Parse(upstream.URL)
incoming.URL.Scheme = upstreamURL.Scheme
incoming.URL.Host = upstreamURL.Host
proxy := &httputil.ReverseProxy{
Director: func(*http.Request) {},
Transport: http.DefaultTransport,
}
proxy.ServeHTTP(httptest.NewRecorder(), incoming)
fmt.Printf("configured endpoint path: %q\n", endpoint.Path)
fmt.Printf("proxied request URI: %q\n", got)
for _, path := range []string{"/llm", "/llm/", "/llm/api"} {
got = ""
incoming, _ = http.NewRequest(http.MethodPost, "http://vanity.example/v1/chat/completions", nil)
incoming.URL.Scheme = upstreamURL.Scheme
incoming.URL.Host = upstreamURL.Host
proxy.ServeHTTP(httptest.NewRecorder(), incoming)
fmt.Printf("base path %q would still proxy as %q\n", path, got)
}
}
EOF
go run /tmp/verify_llm_gateway_path.goRepository: NVIDIA/nvcf Length of output: 3791 🏁 Script executed: #!/bin/bash
set -eu
printf '%s\n' '--- repository guidance ---'
cat -n AGENTS.md | sed -n '1,220p'
if [ -f src/invocation-plane-services/vanity-gateway/AGENTS.md ]; then
cat -n src/invocation-plane-services/vanity-gateway/AGENTS.md | sed -n '1,220p'
fi
if [ -f src/invocation-plane-services/vanity-gateway/AGENTS.md ]; then
cat -n src/invocation-plane-services/vanity-gateway/AGENTS.md | sed -n '1,220p'
fi
printf '%s\n' '--- health helper ---'
cat -n src/invocation-plane-services/vanity-gateway/gateway/health.go | sed -n '29,90p'
printf '%s\n' '--- director tests ---'
cat -n src/invocation-plane-services/vanity-gateway/gateway/llm_gateway_director_test.go | sed -n '1,230p'
printf '%s\n' '--- reverse proxy helper ---'
cat -n src/invocation-plane-services/vanity-gateway/gateway/vanity_director.go | sed -n '160,215p'Repository: NVIDIA/nvcf Length of output: 25474 🏁 Script executed: #!/bin/bash
set -eu
cat >/tmp/verify_llm_gateway_path.go <<'EOF'
package main
import (
"fmt"
"net/http"
"net/http/httptest"
"net/http/httputil"
"net/url"
)
func main() {
endpoint, _ := url.Parse("http://llm-gateway.example/llm")
incoming, _ := http.NewRequest(http.MethodPost, "http://vanity.example/v1/chat/completions", nil)
incoming.URL.Scheme = endpoint.Scheme
incoming.URL.Host = endpoint.Host
incoming.Host = ""
var got string
upstream := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
got = r.URL.RequestURI()
w.WriteHeader(http.StatusNoContent)
}))
defer upstream.Close()
upstreamURL, _ := url.Parse(upstream.URL)
incoming.URL.Scheme = upstreamURL.Scheme
incoming.URL.Host = upstreamURL.Host
proxy := &httputil.ReverseProxy{
Director: func(*http.Request) {},
Transport: http.DefaultTransport,
}
proxy.ServeHTTP(httptest.NewRecorder(), incoming)
fmt.Printf("configured endpoint path: %q\n", endpoint.Path)
fmt.Printf("proxied request URI: %q\n", got)
}
EOF
go run /tmp/verify_llm_gateway_path.goRepository: NVIDIA/nvcf Length of output: 3791 Preserve the configured endpoint path. If 🤖 Prompt for AI Agents |
||
| } | ||
|
|
||
| // UpstreamHostname is the LLM Gateway host without its port, used to reject a | ||
| // configured host that would make the gateway proxy to itself. | ||
| func (d *LLMGatewayDirector) UpstreamHostname() string { | ||
| return hostWithoutPort(d.host) | ||
| } | ||
|
|
||
| func hostWithoutPort(host string) string { | ||
| if hostname, _, err := net.SplitHostPort(host); err == nil { | ||
| return hostname | ||
| } | ||
| return host | ||
| } | ||
|
|
||
| func (d *LLMGatewayDirector) ServeProxy(target LLMGatewayRequest, writer http.ResponseWriter, request *http.Request) error { | ||
| span := trace.SpanFromContext(request.Context()) | ||
| span.SetAttributes(traceAttrEndpointType.String(traceAttrValueEndpointLLMGateway)) | ||
|
|
||
| if writeFunctionStatusError(writer, target.OfflineMessage, target.EOL, "") { | ||
| return nil | ||
| } | ||
|
|
||
| request.URL.Host = d.host | ||
| request.URL.Scheme = d.scheme | ||
| request.Host = "" | ||
| applyCustomHeaders(request, target.CustomHeaders) | ||
|
|
||
| if !target.EOL.IsZero() { | ||
| writer.Header().Set("Deprecation", target.EOL.Format(time.RFC3339)) | ||
| } | ||
|
|
||
| var proxyErr error | ||
| rp := *d.rp | ||
| rp.ErrorHandler = func(writer http.ResponseWriter, request *http.Request, err error) { | ||
| proxyErr = err | ||
| writeProxyError(writer, request, err) | ||
| } | ||
| rp.ServeHTTP(writer, request) | ||
| return proxyErr | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/nvcf
Length of output: 50368
🏁 Script executed:
Repository: NVIDIA/nvcf
Length of output: 29072
🏁 Script executed:
Repository: NVIDIA/nvcf
Length of output: 333
Explicitly discard the handled proxy error.
ServeProxywrites proxy errors through itsErrorHandlerand returns the recorded error. Use_ = llmGatewayDirector.ServeProxy(target, writer, request)to satisfyerrcheck.🧰 Tools
🪛 golangci-lint (2.12.2)
[error] 189-189: Error return value of
llmGatewayDirector.ServeProxyis not checked(errcheck)
🤖 Prompt for AI Agents
Source: Linters/SAST tools