Skip to content

detect version without OS information, update bundle sha as well#2586

Open
rahulait wants to merge 1 commit into
NVIDIA:mainfrom
rahulait:fix-gdrcopy-renovate
Open

detect version without OS information, update bundle sha as well#2586
rahulait wants to merge 1 commit into
NVIDIA:mainfrom
rahulait:fix-gdrcopy-renovate

Conversation

@rahulait

@rahulait rahulait commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

Current auto-generated PR doesn't generate correct output, see: #2585

This PR fixes that for gdrcopy.

Code changes in this PR are drafted with assistance from codex.

To test this PR, one can use:

docker run --rm \
  -v /tmp/renovate-gpu-operator:/repo \
  -w /repo \
  -e RENOVATE_PLATFORM=local \
  -e RENOVATE_CONFIG_FILE=.github/renovate.json \
  -e RENOVATE_ONBOARDING=false \
  -e RENOVATE_DRY_RUN=full \
  -e LOG_LEVEL=debug \
  renovate/renovate:latest 2>&1 \
  | grep -E "gdrdrv|gdrcopy|046063|eef1b666|v2\.6|currentValue|newValue|newDigest|packageFiles with updates"

Sample detected output:

"currentValue": "v2.5.2-rhel9.6",
"packageName": "nvcr.io/nvidia/cloud-native/gdrdrv",

DEBUG: getDigest(https://nvcr.io, nvidia/cloud-native/gdrdrv, v2.6-rhel9.6) (repository=local)
DEBUG: Got docker digest sha256:eef1b6663d78555f0e5c49c156196b67e8a3008bc22aaa02b03dad53887ee0f1 (repository=local)

"depName": "nvcr.io/nvidia/cloud-native/gdrdrv",
"currentValue": "v2.5.2-rhel9.6",
"currentDigest": "sha256:0460630559b0b932c8861237b62e69c2895dace42d37ad3cb02c87e5d751fafc",
"replaceString": "\n      image: nvcr.io/nvidia/cloud-native/gdrdrv@sha256:0460630559b0b932c8861237b62e69c2895dace42d37ad3cb02c87e5d751fafc",
"newVersion": "v2.6",
"newValue": "v2.6-rhel9.6",
"newDigest": "sha256:eef1b6663d78555f0e5c49c156196b67e8a3008bc22aaa02b03dad53887ee0f1",

"depName": "nvcr.io/nvidia/cloud-native/gdrdrv",
"currentValue": "v2.5.2",
"replaceString": "\n  repository: nvcr.io/nvidia/cloud-native\n  image: gdrdrv\n  version: \"v2.5.2\"",
"newVersion": "v2.6",
"newValue": "v2.6",

With this change, both version and sha256sum are calculated and updated correctly.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
@rajathagasthya

Copy link
Copy Markdown
Contributor

@shivakunv How much of this overlaps with #1935?

@shivakunv

Copy link
Copy Markdown
Contributor

@shivakunv How much of this overlaps with #1935?

@rajathagasthya
It will.
Also, the gdrcpy changes in this PR may need to wait until the bare tag release for gdrdrv. Please check the issue:
Bare version tag not published only OS specific tags available · Issue #340 · NVIDIA/gdrcopy

Park Markthub : agreed to release a bare tag for gdrcpy/gdrdrv.

@rahulait
Also, there are some useful fixes in #1935 so we should consider merging it into main. On top of that, we can try a few small fixes.

@rajathagasthya

Copy link
Copy Markdown
Contributor

Ack. Let's coordinate and make sure the right set of changes land.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants